Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200430203845.582900-1-ira.weiny@intel.com> <20200501084634.GH27858@infradead.org>
 <CAMo8Bf+Mvvg_f1-33iQhTqZPVw1civX94KS2mf4uSkcpEVx55Q@mail.gmail.com> <20200501091933.GA3084@infradead.org>
In-Reply-To: <20200501091933.GA3084@infradead.org>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Fri, 1 May 2020 02:50:27 -0700
Message-ID: <CAMo8BfKYii4=_rQK22x4F4n-59KYY9JHKQ6E3H5iJ-N3J63rwg@mail.gmail.com>
Subject: Re: xtensa question, was Re: [PATCH V1 00/10] Remove duplicated kmap code
To:     Christoph Hellwig <hch@infradead.org>
Cc:     ira.weiny@intel.com, LKML <linux-kernel@vger.kernel.org>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@linux-xtensa.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 1, 2020 at 2:19 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Fri, May 01, 2020 at 02:02:19AM -0700, Max Filippov wrote:
> > Hi Christoph,
> >
> > On Fri, May 1, 2020 at 1:46 AM Christoph Hellwig <hch@infradead.org> wrote:
> > > any idea why xtensa uses PAGE_KERNEL_EXEC instead of PAGE_KERNEL
> > > for kmap_prot?  Mapping all mapped highmem as executable seems rather
> > > dangerous.
> >
> > I sure do: to allow instruction cache flushing when writing to high user
> > pages temporarily mapped with kmap. Instruction cache management
> > opcodes that operate on virtual addresses would raise an exception if
> > the address is not executable.
>
> Seems like this should use kmap_atomic_prot with PAGE_KERNEL_EXEC just
> for that case.  Which of course didn't exist on xtensa so far, but with
> this series will.

Yeah, except it's the __access_remote_vm that does the kmap and then
calls copy_to_user_page...

-- 
Thanks.
-- Max