Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp561784ybz; Fri, 1 May 2020 04:26:31 -0700 (PDT) X-Google-Smtp-Source: APiQypLZNKWKLOwtg2jslyJJ1fbfWc5QG2cFJyt8/gmV2yiL0WW8F6xesUsDzT5mZkzR/teQkc8b X-Received: by 2002:a17:906:16ca:: with SMTP id t10mr2770587ejd.122.1588332390978; Fri, 01 May 2020 04:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588332390; cv=none; d=google.com; s=arc-20160816; b=mxWFvGeXDntOKdvTAm2vONqEMTCRxDLG4wbLAvrVYLSiSStU/Fk7288KeKJG9Dq/dY opKqrZFXJTjgH5YZopKVf4C4uZMT7/m3HOK4xeB803yL8THm/ZRFk/mbqBaEoRxV2S95 ml+ZeRIb6/7sXsoA03d3THc6xcn2vPE9UwL3VppEPrmK0svmxwJV5wfw561WKQLCrheV HjbVMN1tYu4YMLgcIAaR76KflQ/SkUOXO3SwTwFv4dqAHa+Tp7LUygoPSVKFxYNzCwkw EzwMNjo5u+k/lIJaE2WY0aA7gI+MGn8AIvyt0RpWIOIINJyfKRLf8mIYFjFKa+BB8hDG Ku9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=k4i37dvct6dci2cxxpCoFaPvtqoehSmhj4hOPSjop+o=; b=CbDzK/7vhucP/hziUQk34loLHnz/7JYoen6oVtjbimom0OIEu/L8CV8PlTVay05hIl TRWdFPxqLV0jl0BZq+rrbpiokihrCpN8ZR9E7w13+kP53iXhRAVvCko4/LyCCy+u3nRc 1qorVP0mpB4iPKZHMz0rRA+Fj6bA/j9W9u8j+B0g4PTz1fWbs/hNiuYOAl4zSld5xQi9 TsAq7v/UYHhnwWryfHNFgL31ONnQYVooEN2y9OS/QwVxNGTqe0O9IvIHEfWNwuJRmNCS lY8cw4WBRL3gJTRr4uofAINrIEIYyK+pe4eHVRbp9GB402atZTBInzS6mljZXOMufva+ mDsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do16si2025360ejc.265.2020.05.01.04.26.07; Fri, 01 May 2020 04:26:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728686AbgEALWC (ORCPT + 99 others); Fri, 1 May 2020 07:22:02 -0400 Received: from 8bytes.org ([81.169.241.247]:40862 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728485AbgEALWB (ORCPT ); Fri, 1 May 2020 07:22:01 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 5836A3A4; Fri, 1 May 2020 13:22:00 +0200 (CEST) Date: Fri, 1 May 2020 13:21:57 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jon.grimm@amd.com Subject: Re: [PATCH] iommu/amd: Fix legacy interrupt remapping for x2APIC-enabled system Message-ID: <20200501112157.GA18423@8bytes.org> References: <1587562202-14183-1-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587562202-14183-1-git-send-email-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 08:30:02AM -0500, Suravee Suthikulpanit wrote: > Currently, system fails to boot because the legacy interrupt remapping > mode does not enable 128-bit IRTE (GA), which is required for x2APIC > support. > > Fix by using AMD_IOMMU_GUEST_IR_LEGACY_GA mode when booting with > kernel option amd_iommu_intr=legacy instead. The initialization > logic will check GASup and automatically fallback to using > AMD_IOMMU_GUEST_IR_LEGACY if GA mode is not supported. > > Fixes: 3928aa3f5775 ("iommu/amd: Detect and enable guest vAPIC support") > Signed-off-by: Suravee Suthikulpanit > --- > drivers/iommu/amd_iommu_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied for v5.7, thanks Suravee.