Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp573150ybz; Fri, 1 May 2020 04:41:32 -0700 (PDT) X-Google-Smtp-Source: APiQypIr32fh6KhWorpiJ2rHOt7huTccSv5Y62Sxiw2vTBUOnGJhaAIlwkJPy1NiV5KxWi10dpx0 X-Received: by 2002:a17:906:68d7:: with SMTP id y23mr2782898ejr.85.1588333292201; Fri, 01 May 2020 04:41:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588333292; cv=none; d=google.com; s=arc-20160816; b=aCSqOVbdD57+0FUqYPrheHpmAAfHd78HtBGI+G1QoCf/gU/4PkEQi+Pfcs9zOFjL2g lF0XNK6x+7qJOWUt6JSgo/lDWfBm7iUteHV3/V2nhkreQQTiOaGnq6fik9/SwTTp4u92 oeui3Nm8WlNKR+8QWN5ca1zqnLbnltbj1HnYgZzEqPToy6QTJpI31/AHqfMJbE6ftUkt oOARrU/VvSo6L8u4PvNGokXWL9g+WMudtp7yITETN7cFCbeddtZD7V0DunxNoUEEcjI2 +M20KV/zApFRUb3408zErRM8vcc/U+IKVEoCZC7sJw1cijLCBVA41lRkgeVtxXYA752q lf5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=hZjyzzTRhy+HIIv46PiZjKsy67TiPSQauvOrxz7sD24=; b=OeDEZyJ1c34AuDC75B+TYSSxszescuZ7qoKg++T0TgCjBAlYYUsf9xwiX2TKkWc4n8 4yvfMyMCXcTaEHP3qnpkB0c1hfN2J0Yh7F6sURfWrbPAMmfilu9g+NzB8FtnEgqrCgLK 92jsATZrXKd7FNNp6rwZMEKK98lNweIHxn1NJiBH9Xi1mh4ao8YqEU4J/43vxrwFAlN0 jRO9zLtfR9z1bYexHWstoUtlxq8pdnQeMJVdEyOKoBxYyW4pifmG6mrNQceRhTvgOPkk 65fQNkZpgmmRwmWnRZNnadtH6Bq/eclqr+zep9x9KEY+vuoqm5C14AFZSszbHPKF+Esj F/Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si1532855ejr.440.2020.05.01.04.41.09; Fri, 01 May 2020 04:41:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728724AbgEALhs (ORCPT + 99 others); Fri, 1 May 2020 07:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728575AbgEALhs (ORCPT ); Fri, 1 May 2020 07:37:48 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B5F0C061A0C; Fri, 1 May 2020 04:37:48 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 08B613A4; Fri, 1 May 2020 13:37:46 +0200 (CEST) Date: Fri, 1 May 2020 13:37:45 +0200 From: Joerg Roedel To: Tang Bin Cc: agross@kernel.org, bjorn.andersson@linaro.org, robdclark@gmail.com, linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2]iommu/qcom:fix local_base status check Message-ID: <20200501113745.GE18423@8bytes.org> References: <20200418134703.1760-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200418134703.1760-1-tangbin@cmss.chinamobile.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 18, 2020 at 09:47:03PM +0800, Tang Bin wrote: > The function qcom_iommu_device_probe() does not perform sufficient > error checking after executing devm_ioremap_resource(), which can > result in crashes if a critical error path is encountered. > > Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu") > > Signed-off-by: Tang Bin > --- > v2: > - fix commit message and add fixed tag > --- > drivers/iommu/qcom_iommu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Applied for v5.7, thanks.