Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp670254ybz; Fri, 1 May 2020 06:32:32 -0700 (PDT) X-Google-Smtp-Source: APiQypI0sn17F2Z27KZGErBzEOWExTp6ocS3Lke1SNxfMDo9rc8/ALEjJD8H6/s/2VXBanYGrp/z X-Received: by 2002:a17:906:7ac8:: with SMTP id k8mr3227714ejo.235.1588339952054; Fri, 01 May 2020 06:32:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588339952; cv=none; d=google.com; s=arc-20160816; b=uZYVqCBpA1rmpGj+df4zdja72OKhpslfv3xRVpA8m2krZWJaBoVDX0OqqjId18YQRB OSrlZgI2BmCHj8eb4xtlpxrrXjxUKuc+ABoUQOTTUQHRYvd5NtF5xnp2JrBXQpxSbzrH hB8lYNcVM3EOD/oyaFi+65JyndqTXWK6pdI/3jtYsW9iN+Zst0DrNE524j2DWj4JCcjg WTom+egR9tFFigBaxGAmD80LYUqgmPjPuxFQtqtnPeAE/KJnHFbq480RSDCuiMJAVZBA L3d7wharBWBKsM+xD4TDHeh9rV00z4+pAB38kC1CRtTG2XJeHxoCH+g0IhEVb7IAeasr 1suA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Wm+dO9NOvUWCBiM7cNYN+0x5UcbbDHovr9l5GCtLfDw=; b=zOx4f2hE7YcwOtpkV55XqSlHP457UwN6B7Ac7mlwBCkfoBCq63Ac5paUtxQfMbg/9m k7Hp+U/orfRMWEfW9wyAEtLLUOOIZ2Guy1hcPTAzYTjW5ct4i+4PX85un7rzE5kA/0bQ zUy+PkDgxOPCtaXNQTJhdYKdUo9/l2GHwfvjlgNu/HbJuXBbOR6TmzGyqAFSr0qlZMf9 KLxXox5cTMNaQOgMDPd3oRCQucgx13p6RW5QniWjIpbZN3Iv1OQPl1k0UaNUxuh7MjMb AMZlXjZ1cZzu+3uK0daO/Pi93mh8QeXian9WoQfLYxcbZiK9Hk/peblUmL8H/6BAIMD6 dYeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e+gfi278; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e25si1696184ejl.159.2020.05.01.06.32.08; Fri, 01 May 2020 06:32:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e+gfi278; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729723AbgEAN27 (ORCPT + 99 others); Fri, 1 May 2020 09:28:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:52304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729158AbgEAN25 (ORCPT ); Fri, 1 May 2020 09:28:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DADEC2173E; Fri, 1 May 2020 13:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339736; bh=kVEuf2gaxCNZnPQLaEEHOFcGlNG9hxk+Tp1dBik2BeI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e+gfi278H7xodGJ6E1rTljW5Ek5TkNAE63TAZX2aeUxeGw0y7lg9UxNcjKPF4SvkM bK6N4SHB5CnAYfz1obPwya8JAQst7xlrdYmKs9zKavxrkLJ+Hb7O+oa9Oa9m62FHJB h+Yq16ZnnD1L1m/eB13cBhaSBXekx2POAv5EMWY8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , Soheil Hassas Yeganeh , "David S. Miller" Subject: [PATCH 4.9 25/80] tcp: cache line align MAX_TCP_HEADER Date: Fri, 1 May 2020 15:21:19 +0200 Message-Id: <20200501131522.465024046@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.810761598@linuxfoundation.org> References: <20200501131513.810761598@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet [ Upstream commit 9bacd256f1354883d3c1402655153367982bba49 ] TCP stack is dumb in how it cooks its output packets. Depending on MAX_HEADER value, we might chose a bad ending point for the headers. If we align the end of TCP headers to cache line boundary, we make sure to always use the smallest number of cache lines, which always help. Signed-off-by: Eric Dumazet Cc: Soheil Hassas Yeganeh Acked-by: Soheil Hassas Yeganeh Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -51,7 +51,7 @@ extern struct inet_hashinfo tcp_hashinfo extern struct percpu_counter tcp_orphan_count; void tcp_time_wait(struct sock *sk, int state, int timeo); -#define MAX_TCP_HEADER (128 + MAX_HEADER) +#define MAX_TCP_HEADER L1_CACHE_ALIGN(128 + MAX_HEADER) #define MAX_TCP_OPTION_SPACE 40 #define TCP_MIN_SND_MSS 48 #define TCP_MIN_GSO_SIZE (TCP_MIN_SND_MSS - MAX_TCP_OPTION_SPACE)