Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp670955ybz; Fri, 1 May 2020 06:33:04 -0700 (PDT) X-Google-Smtp-Source: APiQypJf+TNkhUc/Ph9ZHbhMgwfxWniMjLt9NvOsI/6r7eGpAixmPzg7DR/9nQLqw1n1WDV9X2L+ X-Received: by 2002:aa7:c38a:: with SMTP id k10mr3576270edq.74.1588339984720; Fri, 01 May 2020 06:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588339984; cv=none; d=google.com; s=arc-20160816; b=QebOYZbHau0gho3GXnUf5kf9T87BWJapllfns6e8equmMRtoNMi5vZUl4kQtn+hx1R Tphd3YioKNhYjV2F1gteXCQa4i4b5KhZIqHfUifF8PVoRPDrjP1F5hX2q7g4tyXH3cBA PJDfa1dtJxLBzCvVCABH8yK3rV0w/qtyBFC6jZsL3VHt9bXXAKWHcG9JJbaKHVvzl6b3 +xyOCz2Wo3sMVjd4vQhivWDipJggV6ddU4hbDOXzvSn6HBdsJam1LG80awMhY+r25GKK Tc03hS33EwoYsVMylNoqIBTsEMQ8QmpHuSJlyqyN9dSWx38IZ7/f4R0b0rZm4DrTueNA It0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kHgLODRzbESw02FbHcmatxNIWom/OrG4M68izA2t6rM=; b=c4ueZoiP3anMgUbDAZTIvbBuKJU3skEKmw+8kst+wERgQmDB2ekQA49dxc4RojkuRb epvBlCxyNJSrUgh5M4z+snJlx32/CImMCaFuQg5H9d6gClO0WWtMO9ev5uuphbQfMrxl aILx2xiguIPVI9+E/Z88rZjrmlLGvZCktq0TEQY7D2kMnRAhzncGm1e9dO/1rIxAqoch QH951Tvmf+UVMfN7cJOfDPiXZ38EWGca/bsPopr4yyAJgqxdO4HimswQlZPPLA0c1Q6N +ECpfEq3nWckWMjYL3mdb4rK5v2YPp09XM2nCLREO12Qh4qxDkbPFNTRJUZvMNbNVFm6 FPEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SDmIlfpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f3si1746579edy.68.2020.05.01.06.32.41; Fri, 01 May 2020 06:33:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SDmIlfpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729421AbgEANaM (ORCPT + 99 others); Fri, 1 May 2020 09:30:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:54074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729032AbgEANaK (ORCPT ); Fri, 1 May 2020 09:30:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B781A208D6; Fri, 1 May 2020 13:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339810; bh=2C+zaXH0NcVwovhzxCpIT+U1m1TU7namuJZfIR6ant8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SDmIlfpybFALJLGUvkP7SNyg3QSA5vtqMT4wWwTIrL62oHEDqhZqupPog75S7JsKJ OnMWfSchb4jO/wHmEKuSgtiXfJIL02oiZame6R74hiLHpZUsrAhykM0rbf56d7XmiX G8YnAPzbyFMqwZNItpUT81LDg62qaFYENNpzO0Lc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum Subject: [PATCH 4.9 56/80] UAS: no use logging any details in case of ENODEV Date: Fri, 1 May 2020 15:21:50 +0200 Message-Id: <20200501131530.483623421@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.810761598@linuxfoundation.org> References: <20200501131513.810761598@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 5963dec98dc52d52476390485f07a29c30c6a582 upstream. Once a device is gone, the internal state does not matter anymore. There is no need to spam the logs. Signed-off-by: Oliver Neukum Cc: stable Fixes: 326349f824619 ("uas: add dead request list") Link: https://lore.kernel.org/r/20200415141750.811-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/uas.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -191,6 +191,9 @@ static void uas_log_cmd_state(struct scs struct uas_cmd_info *ci = (void *)&cmnd->SCp; struct uas_cmd_info *cmdinfo = (void *)&cmnd->SCp; + if (status == -ENODEV) /* too late */ + return; + scmd_printk(KERN_INFO, cmnd, "%s %d uas-tag %d inflight:%s%s%s%s%s%s%s%s%s%s%s%s ", prefix, status, cmdinfo->uas_tag,