Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp682653ybz; Fri, 1 May 2020 06:45:01 -0700 (PDT) X-Google-Smtp-Source: APiQypK6WR/0jB8ibTNtXtYHfrff9JQivJA7CVTND9kpS9+Emzqx9GtcNYZKEtGzgEwOUttAJzhL X-Received: by 2002:a17:907:b11:: with SMTP id h17mr3317230ejl.371.1588340701360; Fri, 01 May 2020 06:45:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588340701; cv=none; d=google.com; s=arc-20160816; b=ldT8k9Yu4rMVDGV6Vaf1A7XmPmRzx+SF55fldkgzN9ImL2coPY9ZoQwG84Mrrr0zpS ap32f8IHC+3ghuuy03HzN/zDcoWr7ObEMUTXzx+CBSq3odZ6fyVDE60LQoIAkyVmFfgc p1tBqMLViGj9XCRGGYTlRmUfmhe0HJEyXj2HMys0j/QZNNdBk7DYid5/E3F5pF12VNFW JhqD4xabp/dDNqui3Xk3sc7LD1o/tEWPgE7YeBUb36zxTjI5ESSWBFhPPJnrJj1p47R+ FnYOUgsp6zyBX+rL7jj4lvSvJj8gSZLE/p/e2XMO5lmYaTWsaexf+dhEwGyjKnXxEI1a mIvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gitYGK9u+iaizaOTAKPgf7z+GBPsXfdPLkOnRC7ia3A=; b=vsD5GLoN47gLQPKjgOduui9VI2GkDf6tKO/e1vGKDF9IMsTFIZ6Zh9I90HjflJKuJv aGKjIQOfSvcSMSZKLn7FUaDQb3//zu85NfgV/Fi3R8DkfIQWr6ANuHI80LiTGmuekV5N UmHgeKMrIgL8DReoulyu/nj5usPpRgaQGUE3JJgsemdiAC3jDW0YHYpWmwxzmRty90WQ EL2yNIjqUhcPpeP4Dy/9aGHkDe3skXO/6DXIuWdhky5IPRSlyE0tEKE2unz9melJGXOR 9tXc8nKTV3IuanCf1NsrZWpP2gCVss9DQa0xzdDORfsUYwwJH3rGcJaWzn7seCwYpcuO chjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oUv08YIF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r3si1431809edc.405.2020.05.01.06.44.37; Fri, 01 May 2020 06:45:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oUv08YIF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730668AbgEANlQ (ORCPT + 99 others); Fri, 1 May 2020 09:41:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:41410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731397AbgEANlK (ORCPT ); Fri, 1 May 2020 09:41:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 488D9205C9; Fri, 1 May 2020 13:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340469; bh=h+yf3XfLMMIBkEtIRS1gwvCxk7zvY/MZ7YG4iM+WI90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oUv08YIFvjhZrCtPjdgPK1DpgJdd3xm1jBSd0ympVSu7wh6MiXbcNN6S4h4HyRim+ m1JpFjyjTLGdpWD7CnD36mC66vAI29ahsENQivtBEYioae8jESsDYdy9PFz65+vmJR Lk/xAseaNfmI7rnG2PoPrYZ5/KFdDUyss/Z9JHvo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Olivier Moysan , Mark Brown Subject: [PATCH 5.4 83/83] ASoC: stm32: spdifrx: fix regmap status check Date: Fri, 1 May 2020 15:24:02 +0200 Message-Id: <20200501131543.348279295@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131524.004332640@linuxfoundation.org> References: <20200501131524.004332640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olivier Moysan commit a168dae5ea14283e8992d5282237bb0d6a3e1c06 upstream. Release resources when exiting on error. Fixes: 1a5c0b28fc56 ("ASoC: stm32: spdifrx: manage identification registers") Signed-off-by: Olivier Moysan Link: https://lore.kernel.org/r/20200318144125.9163-2-olivier.moysan@st.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/stm/stm32_spdifrx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/soc/stm/stm32_spdifrx.c +++ b/sound/soc/stm/stm32_spdifrx.c @@ -995,6 +995,8 @@ static int stm32_spdifrx_probe(struct pl if (idr == SPDIFRX_IPIDR_NUMBER) { ret = regmap_read(spdifrx->regmap, STM32_SPDIFRX_VERR, &ver); + if (ret) + goto error; dev_dbg(&pdev->dev, "SPDIFRX version: %lu.%lu registered\n", FIELD_GET(SPDIFRX_VERR_MAJ_MASK, ver),