Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp689100ybz; Fri, 1 May 2020 06:51:59 -0700 (PDT) X-Google-Smtp-Source: APiQypKCpHKOQ7OrPA3tBPt3T+Iq8QtczbigaigZsNbVHzTrlNdyWnT9SlFeLXIqckaLo3ZM0shc X-Received: by 2002:a17:906:5e50:: with SMTP id b16mr3384948eju.331.1588341119425; Fri, 01 May 2020 06:51:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588341119; cv=none; d=google.com; s=arc-20160816; b=rfk6APS08y8vzLte6+DA5vkAW39CKBZhxSt/Qqb9T4T0qXwXyBuLCrIDm5wQIcBSy5 cb1OkA5CZGs+elgI3OTM5uxdyEPn9dpXcwIFXbkihaadlgmaPpIzXU7amLBXCKwHwIz3 inl5haLZlASYQde0200uubxuMoGST35xF3OkhvZ3Tl92J/XMOqdUvfS2ITAhEeCJnnaC DCxwLPeqW7eGISslU80Y3m2ONnKZYD4pU73eG2NLqA5vQeZM4tXBJKwOxxoPcTcHElLa z4X4TrFojtzRk6s2PPl735Ypssb6W03JcfTW23ckZGgighj1O4sQM0Uur0rnpkKjO3G5 9BgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YHwZ0pUKvxoeEqgC45SgXVqGdKQz8Znb4hcl1GfeeQ8=; b=GMx5mcG0wYIvF4F5jn4nzHbSOLImN3/ZDg/Zkm6k/AJlk3+0KsGLLboaxP/b21Uybc BF+GTVDWkV7AoURgoqpbNKKSitxoPBSu8jPcckBZbiuoPUgukVaXlduLf2OkZqzqiuIp AWsook6LckWSWVFneAPhjtkJbY9qrf7RrZjU41kE6SxJUjjkpVmPk/vupTzb1hO2pt/V NpC51limupxKj4srY9iEAXcs5MY1UYTD5HZopZm5+Tj2820zRbBf0hvDX+M0sD9c5Zxo RrF1lW3IElU830ux+mK4YOcjtSW7S27dyp0RhbnEUoTtzAjO4U1jZmUuBsCPxbUGDG65 bD2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HiMPLvNS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si1613233ejs.396.2020.05.01.06.51.36; Fri, 01 May 2020 06:51:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HiMPLvNS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731452AbgEANsK (ORCPT + 99 others); Fri, 1 May 2020 09:48:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:43440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729169AbgEANml (ORCPT ); Fri, 1 May 2020 09:42:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC6B2208DB; Fri, 1 May 2020 13:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340561; bh=I4wRL5poyl2fmkwPf1N4wKbUFGDbAZST9yu47/9xtN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HiMPLvNSatZzDunN2V39jKaJ9LPX/u1EG9Iq/q9YtVHAbDm83iGsLQzCBBNj3yQCe f7lEci4/dBBBh5s0usxLRlXnf+3hZgPQCAxzjsTR+wqKmMqB4iyZuNaZtB2tL5uWql kpFvteZVwyaHbDyXT4m5RM2n9x/QaQHCYiC5zm0I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Holger=20Hoffst=C3=A4tte?= , Guenter Roeck Subject: [PATCH 5.6 032/106] hwmon: (drivetemp) Return -ENODATA for invalid temperatures Date: Fri, 1 May 2020 15:23:05 +0200 Message-Id: <20200501131547.822255949@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131543.421333643@linuxfoundation.org> References: <20200501131543.421333643@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck commit ed08ebb7124e90a99420bb913d602907d377d03d upstream. Holger Hoffstätte observed that Samsung 850 Pro may return invalid temperatures for a short period of time after resume. Return -ENODATA to userspace if this is observed. Fixes: 5b46903d8bf3 ("hwmon: Driver for disk and solid state drives with temperature sensors") Reported-by: Holger Hoffstätte Cc: Holger Hoffstätte Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/drivetemp.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/hwmon/drivetemp.c +++ b/drivers/hwmon/drivetemp.c @@ -264,12 +264,18 @@ static int drivetemp_get_scttemp(struct return err; switch (attr) { case hwmon_temp_input: + if (!temp_is_valid(buf[SCT_STATUS_TEMP])) + return -ENODATA; *val = temp_from_sct(buf[SCT_STATUS_TEMP]); break; case hwmon_temp_lowest: + if (!temp_is_valid(buf[SCT_STATUS_TEMP_LOWEST])) + return -ENODATA; *val = temp_from_sct(buf[SCT_STATUS_TEMP_LOWEST]); break; case hwmon_temp_highest: + if (!temp_is_valid(buf[SCT_STATUS_TEMP_HIGHEST])) + return -ENODATA; *val = temp_from_sct(buf[SCT_STATUS_TEMP_HIGHEST]); break; default: