Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp689213ybz; Fri, 1 May 2020 06:52:07 -0700 (PDT) X-Google-Smtp-Source: APiQypJFS0/DW4y2MsFeUGJCVI0NVsLY7RcMvTAu11qlsMFvxafoAr696TEvZ5AVsnMTS/fXsuWa X-Received: by 2002:a17:906:bce4:: with SMTP id op4mr3067183ejb.174.1588341127237; Fri, 01 May 2020 06:52:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588341127; cv=none; d=google.com; s=arc-20160816; b=Da1BQUgMcoXs9e+mUck9dRUV5o0sVTzEB+7gCRhqQmvEXwmA/esEHsI5Anl2PqVI6m m60c0TmBZCEzo9jbi2z7o0oe6y3z5n+MeAAjrwGN6MHL6/OMeL1tdAOJf19DwzA0KGYs gBU9LiwsBF5Nhm1btQsOAEaV8rnyBwRk/kKXLtfcybPaHZZBRHjUO03la0sYqZMQaL6c rtE2En5W/2bHHpQbZ3LvXSjX6c0bTlRrPocLbfHVhmYME/IHtMX8klwVua9vQlP//8dT UXiixaRWrNs8xQeorGp7dtnRRnqdb3kOwKixeJ2cB+O8SUupzltzFVnbvHEXTlVUYW85 JyGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SfyMJBhHRxEhAzl5IejpmhStd0aUYPkfCZM/zm3SoM0=; b=jidoA8u/xEAzNxES7ZGAsx+0RWm8RCxoUEq3Nlmku1gkMjrTkiSKoxANy7K/ySq76g hsEbQi9n/B57zKDGXIfvVmRKWTMXn0CEZhAbsPP4mX45NFEUYprjeZGHmxe5369mqLXT +CgVR0uqK2mdDYSWw9gBq8Ig8d+mJ0fShTiPkAZM35jexPclbFgRvvQrKM/yZm4ejtTQ ZDPZXzG9wHQubVhyYvVMAbF71X5+QnJBshz1s+hUqMq0iibor0aXQPbOeDBt+rfffAvj vTAqGYCNzeQ7c5bIbmuS52+K2BuaCbaIFbG1xJ9oZdU+CF1y48FiIEclPkAI2hBXMajc 82ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Io3RjrTE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i3si1713617edn.135.2020.05.01.06.51.44; Fri, 01 May 2020 06:52:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Io3RjrTE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730317AbgEANuA (ORCPT + 99 others); Fri, 1 May 2020 09:50:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:40968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729633AbgEANkr (ORCPT ); Fri, 1 May 2020 09:40:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DCAF216FD; Fri, 1 May 2020 13:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340447; bh=1sRtclu5YtF/BdA/p0xwCVoFQqyA2qzRIAsl+w9VUSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Io3RjrTEIkRdRzG2T8iuP7IjvqeqbRLAIhbCzuPWIhsrvi957OJ9E3WkLSltrsihg 6FI9iJQCfi7/5CZk5TiLj1eDqk2tQ1H1Gzs8vgg/RhtRGY8sE76I53bjpr+zbFcs2Q fjd/QUDo1IDlfeR/1Uu9GsOGSOfCb71HaCicHpLU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, yangerkun , Theodore Tso , Ritesh Harjani , Jan Kara , Sasha Levin Subject: [PATCH 5.4 71/83] ext4: use matching invalidatepage in ext4_writepage Date: Fri, 1 May 2020 15:23:50 +0200 Message-Id: <20200501131541.543288760@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131524.004332640@linuxfoundation.org> References: <20200501131524.004332640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: yangerkun [ Upstream commit c2a559bc0e7ed5a715ad6b947025b33cb7c05ea7 ] Run generic/388 with journal data mode sometimes may trigger the warning in ext4_invalidatepage. Actually, we should use the matching invalidatepage in ext4_writepage. Signed-off-by: yangerkun Signed-off-by: Theodore Ts'o Reviewed-by: Ritesh Harjani Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20200226041002.13914-1-yangerkun@huawei.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index b9473fcc110fd..7e0c77de551bb 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2131,7 +2131,7 @@ static int ext4_writepage(struct page *page, bool keep_towrite = false; if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) { - ext4_invalidatepage(page, 0, PAGE_SIZE); + inode->i_mapping->a_ops->invalidatepage(page, 0, PAGE_SIZE); unlock_page(page); return -EIO; } -- 2.20.1