Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp691270ybz; Fri, 1 May 2020 06:54:37 -0700 (PDT) X-Google-Smtp-Source: APiQypKDe3S+N+w4pauFEKby2WwWHk/0FfPzozWwNObdhiJSe285zwnZPLlDDSDI7zBWMGFLPVSW X-Received: by 2002:a50:8716:: with SMTP id i22mr3584217edb.248.1588341277586; Fri, 01 May 2020 06:54:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588341277; cv=none; d=google.com; s=arc-20160816; b=r/2kH2irf2Wndb+1wABljnHFM3JOCWM9LwFCt8sJiNX6+3Wn+b0tfOOSfnISwr1lX6 ofHrUk2alIEzjbPqnhQgUgM/wQG9uH2eJRiiV/8MSN925kdCsdrZnE+DwLoo8GonWrKi 0rzr6PaiRXyoza+ZAFqjf38I3WJWeMf5+GHxri//6LMZs2LUBIk3LGzldcPXeSblqm/o FCVDOWGnek3Acqek+6xWfax8AUvCTci0op0y9DYwViEhEawFG7wsgT8UsmAguP06ywz9 6Fj8oHGafuolCzIg0LrCSvH2y/hRYMAijHa3ypotmRwW2cHNHUs9uzftCo0Jks9K+RCk 2Omw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1NTAjmIu15oVdFyi6HwtGz708ofinj77mhQoNeXuZiw=; b=xkHGzFVXKZmp1hFb6i2L4XtMg4WKiNfFnPmaTlEGOp0q9psSEW9i7bJZW4Ot8BvSCm wP7AtcFViCqldpc21nmDVvLSG+naQVgJafEN1movVwMGb1YFGD1/nVOyuWyhf+W3nWaT LKqrSTab/O2PKr3snplSXNAtp0v62sObLZRChvL1ZRk63AGbw3r4vCG2oTLgjkK3Ts9u EkcX8jBQaZ+vKk+7lBCZJCtjD8no4NKvp7cbXmWOAiB70xgcj9cuPBsqYvpEhz3EwvBH d3t7m6usFSyRM8Qt0F0Knj/zUu1jVJBemXbCW3F1ACay2pp3GE6KBGVe6eiSGYzjlTFX kUCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=abNaf4Br; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si1679605edk.571.2020.05.01.06.54.14; Fri, 01 May 2020 06:54:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=abNaf4Br; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730324AbgEANwR (ORCPT + 99 others); Fri, 1 May 2020 09:52:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:37046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729601AbgEANhr (ORCPT ); Fri, 1 May 2020 09:37:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F30BA24956; Fri, 1 May 2020 13:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340267; bh=XukTGRUrtvKB6T6Dx7YJG9irS2u0oNYCp9zrre1bP/U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=abNaf4Br8ZxLrXqKp+Prb/PkktfHrL6At8xL3j0MRu7lJPMuTfvQXip1RBl60DlRP ktrB1FG3Ffb0xOkr9Q0Tjsq+H3l4mfgZVZyTK26ORg5jaVEIE2nZwea50VzioHei1E 905vOBfGHh9JLjz4bnavyvXcnDu3iAh58Q1Nk7io= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Clement Leger , Bjorn Andersson , Doug Anderson Subject: [PATCH 5.4 01/83] remoteproc: Fix wrong rvring index computation Date: Fri, 1 May 2020 15:22:40 +0200 Message-Id: <20200501131524.384742556@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131524.004332640@linuxfoundation.org> References: <20200501131524.004332640@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Clement Leger commit 00a0eec59ddbb1ce966b19097d8a8d2f777e726a upstream. Index of rvring is computed using pointer arithmetic. However, since rvring->rvdev->vring is the base of the vring array, computation of rvring idx should be reversed. It previously lead to writing at negative indices in the resource table. Signed-off-by: Clement Leger Link: https://lore.kernel.org/r/20191004073736.8327-1-cleger@kalray.eu Signed-off-by: Bjorn Andersson Cc: Doug Anderson Signed-off-by: Greg Kroah-Hartman --- drivers/remoteproc/remoteproc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -400,7 +400,7 @@ rproc_parse_vring(struct rproc_vdev *rvd void rproc_free_vring(struct rproc_vring *rvring) { struct rproc *rproc = rvring->rvdev->rproc; - int idx = rvring->rvdev->vring - rvring; + int idx = rvring - rvring->rvdev->vring; struct fw_rsc_vdev *rsc; idr_remove(&rproc->notifyids, rvring->notifyid);