Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp693175ybz; Fri, 1 May 2020 06:56:52 -0700 (PDT) X-Google-Smtp-Source: APiQypLhzWoXW8upn/dPxcHYXIyXuL+7AXb3mq6dzG/t2ggimhmDgObVzyJHv83rB1k/1ttEDxLK X-Received: by 2002:a17:906:4310:: with SMTP id j16mr3439630ejm.102.1588341412769; Fri, 01 May 2020 06:56:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588341412; cv=none; d=google.com; s=arc-20160816; b=jUvDENMvw2zaN2Yd/f2IbL5K4bJNZd/rftO7C1hzMCEZB0rqAPvPuLzVfWYFwhajL5 HW+bu2+fkRc6U47FQ9yCaevjUIJFIV/Jcprw2YdLkicifdwFdaPvz9yiakBBmupxVW1A 1p1kHHvM09VzTgF4YMksOpmnGqcZ6ZbjZiNAiAgs5jNTtGTGPWpaHzmXDQ7+YLag04Ig kNBtBFn+886nq/iP3SDe2N8F3cG3Q4kO4eQ1TV+KPqsT+WyeFYQl3phfpgPtdATj9E+y x+meRy7+wlGtpup2iU0pJSl7kxpc4XWT3Gdcsgtwp0GP5AVPceQObOOvqZUtCYJJoPxC VAWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ymzQff7WgdSLZ9XY1itar5mF/zTjrO9R3qfU0+hf+ho=; b=MxflrgtVWkYZRSmnlaceA3ilgbtM1KHbRUZ9mp031hkWcL6pWLVtS0C24unf5wsHIE 5vdzcxCcfjSygZDbAvxoKqoghi/ynef6CwycA5wURax6PWUFKCBomPueRrmSEageuz9a l5QxbGJufR5UWvvph9uybwBZxL0wZmnzntoeUSYLx0Vw1VXuSVsn2pmN+jCIi/4fCPAk xXUIavQ1E6uGfrRdohGSMi0nK8zaFh3oXEn2G8a/mSYMyvq/qhJwwl/MdtQVD0vkItaT KBmE5py9gQzRotLxk4qvRMrJwKPxZTMwnYyW+awLOytsJ7nIeA9Jm94BnxzGKYwZhEpm DIZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=trNTNP0x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b24si1659257edr.338.2020.05.01.06.56.29; Fri, 01 May 2020 06:56:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=trNTNP0x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730864AbgEANxv (ORCPT + 99 others); Fri, 1 May 2020 09:53:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:34206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730791AbgEANfv (ORCPT ); Fri, 1 May 2020 09:35:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B84FD24954; Fri, 1 May 2020 13:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340151; bh=Mcz1s08FCgfrrpakRyvfiHZc58gglHOpp4TXO1Or6+0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=trNTNP0xxTIToT/czb4S9mSm5MaS0zRABdxl26TV262Mh1tcHPmq3bgVAD8q0n9Dw AkFaCEaPC0zVUVUolLa42h+HAa++Cs1PRwKbifOVikoRfIcg6UJiwtOdd1Tq3JUsLn Pe3lgg6Lc8thlSuZ5zT9/Gbw/9xYKSe6tTwR1LLc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Clement Leger , Bjorn Andersson , Doug Anderson Subject: [PATCH 4.19 01/46] remoteproc: Fix wrong rvring index computation Date: Fri, 1 May 2020 15:22:26 +0200 Message-Id: <20200501131459.150148012@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131457.023036302@linuxfoundation.org> References: <20200501131457.023036302@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Clement Leger commit 00a0eec59ddbb1ce966b19097d8a8d2f777e726a upstream. Index of rvring is computed using pointer arithmetic. However, since rvring->rvdev->vring is the base of the vring array, computation of rvring idx should be reversed. It previously lead to writing at negative indices in the resource table. Signed-off-by: Clement Leger Link: https://lore.kernel.org/r/20191004073736.8327-1-cleger@kalray.eu Signed-off-by: Bjorn Andersson Cc: Doug Anderson Signed-off-by: Greg Kroah-Hartman --- drivers/remoteproc/remoteproc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -289,7 +289,7 @@ void rproc_free_vring(struct rproc_vring { int size = PAGE_ALIGN(vring_size(rvring->len, rvring->align)); struct rproc *rproc = rvring->rvdev->rproc; - int idx = rvring->rvdev->vring - rvring; + int idx = rvring - rvring->rvdev->vring; struct fw_rsc_vdev *rsc; dma_free_coherent(rproc->dev.parent, size, rvring->va, rvring->dma);