Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp694332ybz; Fri, 1 May 2020 06:58:11 -0700 (PDT) X-Google-Smtp-Source: APiQypJAUtLPZcGcQiLHgH8tDuZ4ttzqJaF6e/a4K8N7D+9ElDGDfYUD4bdxB7BcT7gqTRvWdOmc X-Received: by 2002:a17:906:6a84:: with SMTP id p4mr3498625ejr.21.1588341491490; Fri, 01 May 2020 06:58:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588341491; cv=none; d=google.com; s=arc-20160816; b=zeGp1rcT9EB1sDGdmTPrgxnZsZNtDA8hGOYChedGk9pLrOd/0BZ1JP4p48xat23OgH fd20KxMtyZbGqtUsY86nWn0Oa+4WwF1hwyhp9AVnWdS8bh3XCFsZJ11oVRw2Kl2h63k0 73pE/ZBedjTFm0o3VCpLTtdrvTH1DkDxEVzQCqVuqmZUEmjRLSyZKNiorThGKjNWHXZa ntzFo44rHM6QGUCnZjzL+z8HFP3X6yvgiMTV4bx5WPdqxK/gVi+pGA4R9f4A9H/0nxnZ O8HzthNQUUzus7EFlgIZozlKxQO4Jm77DNlRfq8QvVR1KXPaVIgfNVaXqEX7WhdmFxyv slOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=fdzriW2m0wXxpJAdcCgxNqhTDArivU1JH+t6C7BeCNM=; b=KmUXS7tk1yUZTy74ubMc6dWw668lD+b8xNvZX+BrrMCAokfON1Y0msDRNvLCBKbJj2 ZpQ/kNV69jP33Vvz+9nAPwy0PtLerPILyCxzLtg0KmtcTzhoRxPIqOjShpvno8YFmWuZ 4/yXCYDPMUce9pIw1vA8WLcSvgYYwlVQqr2b8qMxzZW9G9vyLjwbWF92ffbw9+qCGaE9 mL7dyXFCRPWv3eRpPifeSIkgoKYp+k8Cg3if5UoKFbMda7wycMPr3vpZLfeLI8KXBJlU PKoP10ufcuqdeBb9ectx6I9Z5bpK2+ntxWDYK4n1aSlBCFmG7qLXPjuCH1to3P5qlaLH 8U/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ee6qUgJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v3si1911433eja.72.2020.05.01.06.57.48; Fri, 01 May 2020 06:58:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ee6qUgJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731156AbgEANxr (ORCPT + 99 others); Fri, 1 May 2020 09:53:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:34250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730332AbgEANfy (ORCPT ); Fri, 1 May 2020 09:35:54 -0400 Received: from localhost.localdomain (unknown [194.230.155.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB44C208DB; Fri, 1 May 2020 13:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340153; bh=Kh/msCxwRgXFSdlIX3Qt+SXVL5MK1dVNY6zwm0oleMc=; h=From:To:Cc:Subject:Date:From; b=Ee6qUgJzQ6b+ci43bqqzMHTmf0+xPNmN7L9D6usB9g9aRax8uiOnTUpADzEicObyN dKcdpe9WJnwe8I7z+D5GUsfTDv1XN+L0SvEpGJgOBZ6hn6c6M+BmIlN4H7jC57vN5N rdl51T06Pc1CcE9/HRor9YfRQ9ArTGiT2tG9wBtc= From: Krzysztof Kozlowski To: Liam Girdwood , Mark Brown , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: patches@opensource.cirrus.com, Lee Jones , Jonathan Bakker , Krzysztof Kozlowski Subject: [PATCH] dt-bindings: sound: wm8994: Correct required supplies based on actual implementaion Date: Fri, 1 May 2020 15:35:34 +0200 Message-Id: <20200501133534.6706-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The required supplies in bindings were actually not matching implementation making the bindings incorrect and misleading. The Linux kernel driver requires all supplies to be present. Also for wlf,wm8994 uses just DBVDD-supply instead of DBVDDn-supply (n: <1,3>). Reported-by: Jonathan Bakker Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/sound/wm8994.txt | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/wm8994.txt b/Documentation/devicetree/bindings/sound/wm8994.txt index 68cccc4653ba..367b58ce1bb9 100644 --- a/Documentation/devicetree/bindings/sound/wm8994.txt +++ b/Documentation/devicetree/bindings/sound/wm8994.txt @@ -14,9 +14,15 @@ Required properties: - #gpio-cells : Must be 2. The first cell is the pin number and the second cell is used to specify optional parameters (currently unused). - - AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, CPVDD-supply, - SPKVDD1-supply, SPKVDD2-supply : power supplies for the device, as covered - in Documentation/devicetree/bindings/regulator/regulator.txt + - power supplies for the device, as covered in + Documentation/devicetree/bindings/regulator/regulator.txt, depending + on compatible: + - for wlf,wm1811 and wlf,wm8958: + AVDD1-supply, AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, + DCVDD-supply, CPVDD-supply, SPKVDD1-supply, SPKVDD2-supply + - for wlf,wm8994: + AVDD1-supply, AVDD2-supply, DBVDD-supply, DCVDD-supply, CPVDD-supply, + SPKVDD1-supply, SPKVDD2-supply Optional properties: @@ -73,11 +79,11 @@ wm8994: codec@1a { lineout1-se; + AVDD1-supply = <®ulator>; AVDD2-supply = <®ulator>; CPVDD-supply = <®ulator>; - DBVDD1-supply = <®ulator>; - DBVDD2-supply = <®ulator>; - DBVDD3-supply = <®ulator>; + DBVDD-supply = <®ulator>; + DCVDD-supply = <®ulator>; SPKVDD1-supply = <®ulator>; SPKVDD2-supply = <®ulator>; }; -- 2.17.1