Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp698860ybz; Fri, 1 May 2020 07:02:16 -0700 (PDT) X-Google-Smtp-Source: APiQypKyI/zu0axlNCI3QEg1VcJQUFqs3yR78v9Agr2WQ/8i4Q2Ma7CtmWejPbNjLlP013DjF3Vs X-Received: by 2002:adf:e711:: with SMTP id c17mr4545629wrm.334.1588341735940; Fri, 01 May 2020 07:02:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588341735; cv=none; d=google.com; s=arc-20160816; b=UDvGL0jALnjzg/90gUyQsm9vw9ptZjTi/Wp182e9uja0DD/lkRe8mT45hGlGhy8vPh 7JO8TxIt755uzRBW8+Z9NQF3uHrArCGQvUIbLFwdl+4kEtja/KT1FXZxCZEXwO0561YM 7dmb2Jg08lA3CtaxL90aSicBxsXqeYmUKoQt6wme2/l04ptJfr1e0HJmYRga2MHAqPX8 SVRVMTdCNo/PVrvMUNONl1fDhoTA5WJwy7+u0YjdWJfWrWt3vyu9xs2eCSmVO7RgpJRN riaeMcoa3cKJzNRN66cT87TCOeeVJigMbGQQX5cNtNdtGPbILkO3a6H+McGNEvy4pZzY 54yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vi+6m/IyxS448Tb+w85FW238aLI3HVAzPRIs1KRnraw=; b=hMRHO+b7q16qc8ilpRVUba+DbL9WXrNNKvxe2mMAO/OXTtk/B0UWiflDmfh4ncXX0H d+BGrAihRe/Tl+HNJy1ZqtV3HhqCngX+GfGaSPH5eMeD8H1KfnQQQcfjP2m0xiu7S9zG r8+5ntb8OD+X9Enju/Dp0qK/AFiyk9AFmLKJ9z1GAnYof3JYdO+ZsNwPKeIzYb9hl9pM 5HRaRfCVHi3U5sndk4pFKP+QlOwkpKgkvB7BnFcrf0inlhiVYWUYAXZrT1D6POeSksHm nicVNMI2gpb4q8fCyA0zGvNkwsjf6BKJbyiCBe4Ksrx76KrVpg4M69qvT5SCCSu+2RHR eKGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="1s/ruaSE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c23si1692912edy.407.2020.05.01.07.01.49; Fri, 01 May 2020 07:02:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="1s/ruaSE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729480AbgEANbe (ORCPT + 99 others); Fri, 1 May 2020 09:31:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:56116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730151AbgEANbb (ORCPT ); Fri, 1 May 2020 09:31:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0BCE208DB; Fri, 1 May 2020 13:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339891; bh=AZDbR3+DwhncfRB/3LcL6iiSnYl24c+VsfbZA8eIE5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1s/ruaSEROGC1xZO/bCCXtpYLrHnZDaMTHIhnHwPbWuKsKfEMWuA6YGNK0eHDKH32 BSwsvMdE8UR22ILmU/qxhl853/a1RaUlXKqXFcvDspe8Ykacqm0ryOW2Y+ANDmSmU0 r2WXZsvQr47JB3crZYBjTp8h28dpUODxheTcGfIs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tero Kristo , Guenter Roeck , Wim Van Sebroeck , Sasha Levin Subject: [PATCH 4.14 008/117] watchdog: reset last_hw_keepalive time at start Date: Fri, 1 May 2020 15:20:44 +0200 Message-Id: <20200501131546.173077545@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131544.291247695@linuxfoundation.org> References: <20200501131544.291247695@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit 982bb70517aef2225bad1d802887b733db492cc0 ] Currently the watchdog core does not initialize the last_hw_keepalive time during watchdog startup. This will cause the watchdog to be pinged immediately if enough time has passed from the system boot-up time, and some types of watchdogs like K3 RTI does not like this. To avoid the issue, setup the last_hw_keepalive time during watchdog startup. Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20200302200426.6492-3-t-kristo@ti.com Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Sasha Levin --- drivers/watchdog/watchdog_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c index b30fb637ae947..52e03f1c76e38 100644 --- a/drivers/watchdog/watchdog_dev.c +++ b/drivers/watchdog/watchdog_dev.c @@ -245,6 +245,7 @@ static int watchdog_start(struct watchdog_device *wdd) if (err == 0) { set_bit(WDOG_ACTIVE, &wdd->status); wd_data->last_keepalive = started_at; + wd_data->last_hw_keepalive = started_at; watchdog_update_worker(wdd); } -- 2.20.1