Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp701593ybz; Fri, 1 May 2020 07:04:19 -0700 (PDT) X-Google-Smtp-Source: APiQypJLiKFDmAscbIgDf7g/c7eMOlPgr3cNqpkwTcYOdwvnAcUXMNadIT9U9pNI44dijXMmlYJf X-Received: by 2002:a17:906:4548:: with SMTP id s8mr3199170ejq.349.1588341858976; Fri, 01 May 2020 07:04:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588341858; cv=none; d=google.com; s=arc-20160816; b=xYv0T/U2UPy4DAliz7gTdSXsoQAcEeC7bHLS1zl9b/3Fi1OY4cyUd+83xTEjV99S/Z vg6mKwIJgHEfoInwyMGB1wuSWYFG0ZlTNvMX2qYkSqFBKHRLSitNSOSWq3STiOxx+blJ huQaf5rEVD9KaTroVssRsA0GGxiJWmuznKSaZ046elNBaCK+njf1bxUAajkTCmi1Ijd2 ry5UjuSMi+tj4bfhbc1b4fVfJKfg+yypz/l5QEwDasN7UTr3dmYc+gGJBy2ETyrdWo5p uHerIvWNvgHuzAF+er4T8zqO37hjmoDYiJSD8dBA1Tu/SD7Ekd8rhAcMRp6hHyTKCnT7 mgDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HW0R2/LEnZ167scLfveuLWq3HmOFwii6ZliqnR40+Yg=; b=gUNTxm6mFm3mKNsAMDi2T7X6pAVypTDmbJWCQ1tPpLxcmjClM6Q228CsAisLMWFOG8 rciNFp9mV00sa5643nw2XqyyQz21LCWN9O83TPy9jLaR6t48vUUgcT8PqymDAQmRKiCy gt2nn4bypDupT96jD65eivc2mMqsZP9XlA7g9Hg7cPZBrgMORA0YA8dOT4i/5iek8v2Q E0vVxb3uN5X99nZYYGfD70P8qI+4xNOjM4ZHj7WTW1NQBAhhxGZ2+iyhrMarXpxYp7Pv TW+1Du0fCUri5EPzcIPiQ8F9pliK+YCVz6riwVg3+rBOFMt8HUngto1OHtzGWX13ZSvC t/7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=crYn1M2b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dv11si1772051ejb.136.2020.05.01.07.03.54; Fri, 01 May 2020 07:04:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=crYn1M2b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729894AbgEAN6m (ORCPT + 99 others); Fri, 1 May 2020 09:58:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:54028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729880AbgEANaI (ORCPT ); Fri, 1 May 2020 09:30:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45BC2208DB; Fri, 1 May 2020 13:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339807; bh=GGWQ67jdRD0wSmMauQa4FV3WSwv4RIz4968TpQMGWfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=crYn1M2bqoD/YU7gzHMGhfyG2iLHhfZGpcdDPUt5M2JA09qjVR4+nVtG84nJ3AmBq CD4C+1cjwrBbHoPTMYIS4TrOCyAq7AoDYYoNhQeH9jYiQPxwjHFGLLru2U1gOdnpyZ 9W7XBCpjhofRIiItBZBBwv2PPXW2NiQhZcFFWxI4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Malcolm Priestley Subject: [PATCH 4.9 55/80] staging: vt6656: Power save stop wake_up_count wrap around. Date: Fri, 1 May 2020 15:21:49 +0200 Message-Id: <20200501131530.323188055@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.810761598@linuxfoundation.org> References: <20200501131513.810761598@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Malcolm Priestley commit ea81c3486442f4643fc9825a2bb1b430b829bccd upstream. conf.listen_interval can sometimes be zero causing wake_up_count to wrap around up to many beacons too late causing CTRL-EVENT-BEACON-LOSS as in. wpa_supplicant[795]: message repeated 45 times: [..CTRL-EVENT-BEACON-LOSS ] Fixes: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.") Cc: stable Signed-off-by: Malcolm Priestley Link: https://lore.kernel.org/r/fce47bb5-7ca6-7671-5094-5c6107302f2b@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6656/int.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/staging/vt6656/int.c +++ b/drivers/staging/vt6656/int.c @@ -153,7 +153,8 @@ void vnt_int_process_data(struct vnt_pri priv->wake_up_count = priv->hw->conf.listen_interval; - --priv->wake_up_count; + if (priv->wake_up_count) + --priv->wake_up_count; /* Turn on wake up to listen next beacon */ if (priv->wake_up_count == 1)