Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp702986ybz; Fri, 1 May 2020 07:05:25 -0700 (PDT) X-Google-Smtp-Source: APiQypI430PAMeX2UfJx7qg0WTopNKn7oYwTsckrIJMFO0W4bhyMpf6a42RRj5+Akf+pbM6xy2vT X-Received: by 2002:a17:906:841a:: with SMTP id n26mr3478364ejx.43.1588341924825; Fri, 01 May 2020 07:05:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588341924; cv=none; d=google.com; s=arc-20160816; b=LAOW7x9KTya6wdP1ADism4FbQiPFGJOvQqKTyQHgUDaKB+Eed2EAGVfA6vKVfJn07h aROUTd//TxcKy+jXflS+f5e0yoIyv+nuf/GSI35ibU/6TmHBLJ0F4LkXjd5jxm75OvME cW0sk0eQKaI/1B1dARwBd0JkecDGmJrg9ivPtb5efMpMnBpgEsUB7BPDbBz9gnPMbf0b MBv8lquAZ0CdVKGER2USCbkQCqN9Z1lEj1WljuA8BBgdoLvol6eMGtfyJK1wHFdKFNx2 LHMUTFfe26bpRgPcFCePvYnY6R5kh/ct3dHJUMxoeUK1xJg2RsBvRE4gJijl1kTZq1LS s4Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kHgLODRzbESw02FbHcmatxNIWom/OrG4M68izA2t6rM=; b=L34VhD8AwT3zLDMK6SFLLgQ98Sif16iUEt1/oEAwMbzTiIUTzxi3ViyoWYhSVLKpnE M9QZulnw4lrCN7CHWX8ZoPi0VfK5RmbTsnFa8OwIPW6Xjmanre9y5EKlHHd2pAJ3w7tQ D+o7dgIzfGgk4Y5Vr4fCafLk8G6Fo4WBcTs8dRdIxLfvJ11zvjnCnSayxUPqa0pFA1d1 GbFVEuVqP1QS+AgsYSbH8IJsur/SjrDSbOZPMhbJQGvWNiim3qLoThKwh/t87cY2od8h K8wv/1Zh0eOtbRrIk3R4m1oKCsQJhLe9lojh/wMDfZHtYP4fpwS6+cPL9FrI+13GpZ+p YMIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OeqCCltu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si1624204edj.220.2020.05.01.07.05.01; Fri, 01 May 2020 07:05:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OeqCCltu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729280AbgEAN0e (ORCPT + 99 others); Fri, 1 May 2020 09:26:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:48286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729266AbgEAN0b (ORCPT ); Fri, 1 May 2020 09:26:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9996C2166E; Fri, 1 May 2020 13:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339591; bh=2C+zaXH0NcVwovhzxCpIT+U1m1TU7namuJZfIR6ant8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OeqCCltue2xirhxZMjDiOwgT6sXlbk5f/Inj+mSCAym5GWmCvoGLQ+oPk/LTAVkS5 oZSCW2CyterWok1i/+WBrJeWRbSQMWkoj3as51IuluVajr80nIYzMyS023M3AaVJQE gggXCS9IV58laQ10Pn/as2DAThc9MiS3xzf1Wifg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum Subject: [PATCH 4.4 51/70] UAS: no use logging any details in case of ENODEV Date: Fri, 1 May 2020 15:21:39 +0200 Message-Id: <20200501131529.217441706@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.302599262@linuxfoundation.org> References: <20200501131513.302599262@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 5963dec98dc52d52476390485f07a29c30c6a582 upstream. Once a device is gone, the internal state does not matter anymore. There is no need to spam the logs. Signed-off-by: Oliver Neukum Cc: stable Fixes: 326349f824619 ("uas: add dead request list") Link: https://lore.kernel.org/r/20200415141750.811-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/uas.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -191,6 +191,9 @@ static void uas_log_cmd_state(struct scs struct uas_cmd_info *ci = (void *)&cmnd->SCp; struct uas_cmd_info *cmdinfo = (void *)&cmnd->SCp; + if (status == -ENODEV) /* too late */ + return; + scmd_printk(KERN_INFO, cmnd, "%s %d uas-tag %d inflight:%s%s%s%s%s%s%s%s%s%s%s%s ", prefix, status, cmdinfo->uas_tag,