Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 May 2020 10:21:13 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Li Philip <philip.li@intel.com>,
        Liu Yiding <yidingx.liu@intel.com>,
        Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 0/3] selftests/ftrace: Fix ftracetest testcases for
 dash, etc.
Message-ID: <20200501102113.151d38c1@gandalf.local.home>
In-Reply-To: <158834025077.28357.15141584656220094821.stgit@devnote2>
References: <158834025077.28357.15141584656220094821.stgit@devnote2>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


[ FYI, Shuah responds better from her linuxfoundation.org email ]

Shuah,

Feel free to take the first two patches of this series (I acked one, and
reviewed the other).

The last patch I had some issues with, and is still under discussion.

Thanks!

-- Steve


On Fri,  1 May 2020 22:37:31 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Hi,
> 
> Here are some patches to update ftracetest to fix some issues.
>  - [1/3] Fix coloring of XFAIL
>  - [2/3] Fix a testcase not to expect just one event entry
>  - [3/3] Do not use built-in echo because the behavior is different
>          on dash and bash. (Thanks Liu for reporting!)
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (3):
>       selftests/ftrace: Make XFAIL green color
>       selftests/ftrace: Pick only the first kprobe event to test
>       selftests/ftrace: Use /bin/echo instead of built-in echo
> 
> 
>  tools/testing/selftests/ftrace/ftracetest          |    2 +-
>  tools/testing/selftests/ftrace/test.d/functions    |    3 +++
>  .../ftrace/test.d/kprobe/kprobe_args_type.tc       |    2 +-
>  .../test.d/trigger/trigger-trace-marker-hist.tc    |    2 +-
>  .../trigger-trace-marker-synthetic-kernel.tc       |    4 ++++
>  .../trigger/trigger-trace-marker-synthetic.tc      |    4 ++--
>  6 files changed, 12 insertions(+), 5 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>