Message-ID: <440EC20D.3090004@cluded.net>
Date: Wed, 08 Mar 2006 11:37:49 +0000
From: "Daniel K." <daniel@cluded.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060307 SeaMonkey/1.5a
MIME-Version: 1.0
To: Eric Sesterhenn <snakebyte@gmx.de>
CC: linux-kernel@vger.kernel.org, raupach@nwfs1.rz.fh-hannover.de
Subject: Re: [Patch] Fix dead code in cdrom/gscd.c
References: <1141808871.6355.5.camel@alice>
In-Reply-To: <1141808871.6355.5.camel@alice>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 804
Lines: 31

Eric Sesterhenn wrote:
> hi,
> 
> this fixes Coverity Bugs #21 and #22. In both cases the
> do { ... } while (result != 6 || result == 0x0E) just

This is completely wrong, and should be fixed too.

Either

	do { ... } while (result != 6)

is correct, or this is the result of a thinko, and it should be

	do { ... } while (result != 6 && result != 0x0E)

in which case your patch is incorrect.

> finishes for result == 6, so the if(result != 6) doesnt
> make much sense.

Unless its presence is an indication of faulty logic in the while clause


Daniel K.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/