Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp792103ybz; Fri, 1 May 2020 08:37:31 -0700 (PDT) X-Google-Smtp-Source: APiQypJydWYiWN14/7TsI+veF2spxVq8SRsMd7EGi9bfyTHIGvxLaN/UurhlCVaRf/dvoPKOTD21 X-Received: by 2002:a17:906:3da:: with SMTP id c26mr3840948eja.290.1588347450872; Fri, 01 May 2020 08:37:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588347450; cv=none; d=google.com; s=arc-20160816; b=yuQdSwYPFp1Rd7WBTTm02vFN9QAPMsBJNGmOlHckG6YRWoqqmSvo+D2IBuLiDgyw7u ZK6vJxYROMTLNiXYuVsOYWOoSb6zv+ImKO6evcsGMU4Hosoa1NNJY+zsuWxVFqNPD28s roMsU5ICeppWSCfXjK/AGx1wouNJtf4oIJjtnpEYccvIC/YyFm9UeaBmkdn4xaoXmcFk JeB8CXFgZxY7fEWk/V3EnwnG1MgGVuGWGFaIXHXBwYm4XaekQHHlnEl+pa4T6X9b7Sqh nUn4OmDTdhwthd9HqFGz7eTuV1NJeAVafbtCRmQoFQNEpvasaIhO37L183gd/sGMmZSk cnqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=OVGNTTsIXilZE/mIAgswxp17k1GWIaGH4stxbXUcyh0=; b=z/wwEifNqr0h36yhn8kP5Xm5Zl5WTr/bBBjZeInC4RvG35faPwKOBGL6ufWgsvJA75 ruI/W/u1NZSXUc8v5tUtzHUdcnF8qBtxTaw/u8DjU8nM/huLvOWr3gmS928StoOfGdiI u4QnLFO6YGV+grJBGuc5J3CusAccfMv/oiBGUwY54AHbFBsyVxbQvg4ZVRJC6gYe8cXn BOs/kz5PpN1nnSA1jTL+qiO+d37mokhE0fS+tw5+ou1D+eNTgVBfEBNfTzEyh51nLFWj 1sekcRvSk9qLCLgDqh8W68+ANR5egbI3TgI8IofKQzqt83eF/0vqZjJN5uWQfk5WLO6O TbSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ufJ9ndRE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a6si1923741eju.62.2020.05.01.08.37.05; Fri, 01 May 2020 08:37:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ufJ9ndRE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729474AbgEAPfj (ORCPT + 99 others); Fri, 1 May 2020 11:35:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729269AbgEAPfi (ORCPT ); Fri, 1 May 2020 11:35:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3CBBC061A0C; Fri, 1 May 2020 08:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OVGNTTsIXilZE/mIAgswxp17k1GWIaGH4stxbXUcyh0=; b=ufJ9ndREHi/ST+gjq87NpeNtn5 hS2gK6+ZL7QtopBXMdN/oP1STPMHM+tKKg9AjO+f9xN3wxbSCMt7njj82dI8dzO8ynWmBT1XzCi1o M+Vj1cNeSxmCnhJDLFOM+ofphWPIGzD+4w9X0SkF6VZDulHJ5780tR2xMP7q7UavjKjM2qBd9KOYJ JmhxHlasPHIzLhYvrjluaVZZWDw0D5TNbkKn+3YKuje9vURfzftd6mc5lwiHCi8wC3G5LEM0ntVIg xxsfRXdsr1C53oK6K0XWK8CYrFKjlL/OrQs6gfiNEsFPAEzTtr1NKir7GUBhBv0Sn26b2COCyrUdJ qjcI9VfQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUXhS-0006PB-Df; Fri, 01 May 2020 15:35:38 +0000 Date: Fri, 1 May 2020 08:35:38 -0700 From: Christoph Hellwig To: Denis Efremov Cc: linux-block@vger.kernel.org, Willy Tarreau , Christoph Hellwig , Joe Perches , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] floppy: use print_hex_dump() in setup_DMA() Message-ID: <20200501153538.GB12469@infradead.org> References: <20200501134416.72248-1-efremov@linux.com> <20200501134416.72248-2-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200501134416.72248-2-efremov@linux.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2020 at 04:44:13PM +0300, Denis Efremov wrote: > Remove pr_cont() and use print_hex_dump() in setup_DMA() to print the > contents of the cmd buffer. > > Suggested-by: Joe Perches > Signed-off-by: Denis Efremov Looks good, Reviewed-by: Christoph Hellwig