Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp794652ybz; Fri, 1 May 2020 08:40:15 -0700 (PDT) X-Google-Smtp-Source: APiQypJMQtTZIFwxVsiMuf+3T3EoPYNoL3dvR0pt5+zHMJcnBobyi6p1omYfXY5bdSI9Hlb8lqRW X-Received: by 2002:a05:6402:3121:: with SMTP id dd1mr4134837edb.168.1588347615775; Fri, 01 May 2020 08:40:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588347615; cv=none; d=google.com; s=arc-20160816; b=Njj7Ngr6AseGG8ubyZTNBpU52J1wZ4PuRCrwj9uBT3vbwRvjJOJUEChS8Q42TAzC3K z6WwU3habkjCBQmm4KPamTxk7H4zjF2V8vHWyzK+QpwGap+Tm9Jv+sscOltzJRE3N8oU G16hSW778+E8Y36mDAUAJZRxBy5QNFhRdeT3kvcsSCApHqr/7hw/laEK0x0HVOqVA+NO gHbjSpMld3JELSbZvM26aBEIJbM6cLSn2KG8SUe/IekfipnYxgbEZQE1GiFaYpcl9EwE 7HfcjpYK1rfxGgAZ6KE1KFMxu8V/2PXEC9jwJVYsnmpdzwt4U0DEei/IybxdvwjF9hMq Gh5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=HsrfycC9F4gKazlY38RjqD/p4LVNAXXHW9C6abpgCD4=; b=emu6n2hmLaZtQiZuyyY0mpQ89LJ18dZZTizlrf3GNVRqe3uGMqHuWmK/WHDp542B5q iFkCkZ2Elh5crHNdXpHwYh03I9ImF6yEtWaNlvu/nUaLwN37189w1fZtESQipEhgHXzr YcJRvVCebfzmwenQeJns9Bx8h8H8BsXfbPaS2wzvFZqzq0zvnu9pMh0kRIsblbTNNpwt Q5soUZZufvvHHLvvVhsBYjyZhv62ZtHm0YFUs9/DPZwcghDg/7b1GE3vg5lQe2AxlkZR q5OGgyGLsAECXpRZ4jqTn2QYq8Qenkw9HikfYdD32svLQLGm8u23YLRqI9CAnP+tXzdH +2Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=gUq93X7u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cb8si2033454ejb.96.2020.05.01.08.39.52; Fri, 01 May 2020 08:40:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=gUq93X7u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729782AbgEAPgB (ORCPT + 99 others); Fri, 1 May 2020 11:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729192AbgEAPgA (ORCPT ); Fri, 1 May 2020 11:36:00 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B95FEC061A0C; Fri, 1 May 2020 08:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HsrfycC9F4gKazlY38RjqD/p4LVNAXXHW9C6abpgCD4=; b=gUq93X7ub8035oC97Ilk3m/Oje QO28Jw9UtfshJEL1j7z4GkCeUtAeGUe3nwbyYz7rdav/6UzfN4WriB/Chnc4DtD4D+oB52TvqrdP5 5bIm8qgpd5B1H5ITfQl61+enY8j4KQ1xvx+ergx5pObGzDMU5b+ctje6L1tlDCCdXxd8f/VvasYAR VHDzsN0kXZ6dA3Codnydpt0fyWNQWzi0A4YWRM9dJ/Hj4/eTucDnmHfIR+9Te05t3cNLIsMXj/hne CGF3jp1gz2X8UQW74diVJJsxM9wTOTCPvSlLpQ0HpAraVWUHiaXRcGd3IxEMYfHRm+SRyRPkRslfu O5t1EV5Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUXho-0006lH-Gd; Fri, 01 May 2020 15:36:00 +0000 Date: Fri, 1 May 2020 08:36:00 -0700 From: Christoph Hellwig To: Denis Efremov Cc: linux-block@vger.kernel.org, Willy Tarreau , Christoph Hellwig , Joe Perches , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] floppy: add FD_AUTODETECT_SIZE define for struct floppy_drive_params Message-ID: <20200501153600.GC12469@infradead.org> References: <20200501134416.72248-1-efremov@linux.com> <20200501134416.72248-3-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200501134416.72248-3-efremov@linux.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2020 at 04:44:14PM +0300, Denis Efremov wrote: > Use FD_AUTODETECT_SIZE for autodetect buffer size in struct > floppy_drive_params instead of a magic number. Looks good, Reviewed-by: Christoph Hellwig