Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <752db40d-5aed-4a97-a050-bc1376547f87@xilinx.com> <20200428100350.12699-1-matwey@sai.msu.ru>
In-Reply-To: <20200428100350.12699-1-matwey@sai.msu.ru>
From:   "Matwey V. Kornilov" <matwey.kornilov@gmail.com>
Date:   Fri, 1 May 2020 19:10:08 +0300
Message-ID: <CAJs94Eb0k-Yf7FrOJwyusBqnYvnxsbD=2vxybbSAvLg0ZJ210w@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: dts: zynq: Fix ethernet PHY for v5 schematics
To:     Rob Herring <robh+dt@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/ZYNQ ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        Anton Gerasimov <tossel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Anton,

I hope you are doing good. Could you please check this patch, since
you are initial author of zynq-zturn.dts and I suppose you do have the
"v4" board variant to test.

=D0=B2=D1=82, 28 =D0=B0=D0=BF=D1=80. 2020 =D0=B3. =D0=B2 13:04, Matwey V. K=
ornilov <matwey@sai.msu.ru>:
>
> There are at least two different versions existing for MYIR Zturn:
>
>  * v4 schematics has Atheros AR8035 PHY at 0b000
>      http://www.myirtech.com/download/Zynq7000/Z-TURNBOARD_schematic.pdf
>  * v5 schematics has Micrel KSZ9031 PHY at 0b011
>      v5 schematics available at DVD disk supplied with the board
>
> Specify both PHYs to make ethernet interface working for any board
> revision. This commit relies on of_mdiobus_register() behavior.
> When phy-handle is missed, every nested PHY node is considered,
> while ENODEVs are ignored.
>
> Before the patch:
>
> [   28.295002] macb e000b000.ethernet eth0: Could not attach PHY (-19)
>
> After the patch:
>
> [   28.257365] macb e000b000.ethernet eth0: PHY [e000b000.ethernet-ffffff=
ff:00] driver [Micrel KSZ9031 Gigabit PHY] (irq=3DPOLL)
> [   28.257384] macb e000b000.ethernet eth0: configuring for phy/rgmii-id =
link mode
>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>

Cc: Anton Gerasimov <tossel@gmail.com>

> ---
> Changes since v1:
>  - reworded commit message
>
>  arch/arm/boot/dts/zynq-zturn.dts | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zt=
urn.dts
> index 5ec616ebca08..07da9cf60d02 100644
> --- a/arch/arm/boot/dts/zynq-zturn.dts
> +++ b/arch/arm/boot/dts/zynq-zturn.dts
> @@ -67,10 +67,17 @@
>  &gem0 {
>         status =3D "okay";
>         phy-mode =3D "rgmii-id";
> -       phy-handle =3D <&ethernet_phy>;
>
> -       ethernet_phy: ethernet-phy@0 {
> -               reg =3D <0x0>;
> +       ethernet-phy@0 {
> +               compatible =3D "ethernet-phy-ieee802.3-c22";
> +               reg =3D <0>;
> +               max-speed =3D <1000>;
> +       };
> +
> +       ethernet-phy@3 {
> +               compatible =3D "ethernet-phy-ieee802.3-c22";
> +               reg =3D <3>;
> +               max-speed =3D <1000>;
>         };
>  };
>
> --
> 2.16.4
>


--=20
With best regards,
Matwey V. Kornilov