Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 May 2020 19:16:18 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Josh Poimboeuf <jpoimboe@redhat.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Remaining randconfig objtool warnings, linux-next-20200428
Message-ID: <20200501171618.GF3762@hirez.programming.kicks-ass.net>
References: <CAK8P3a2qLJkokMGt48JRky=WUeAbJRuNmoD1oqfWdrGSC6y1LA@mail.gmail.com>
 <CAK8P3a2Gzj9SVZSGo+PxWR0cMJb1sFwv+ii9J6jEGE-Z41Fr+A@mail.gmail.com>
 <20200501002858.4wuiqqv5o32jcvxf@treble>
 <CAK8P3a3_aC9rJDXta+6D2Oq5RSJgfXaT5-wFU_tM-6x7unbuPg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK8P3a3_aC9rJDXta+6D2Oq5RSJgfXaT5-wFU_tM-6x7unbuPg@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 01, 2020 at 01:41:30PM +0200, Arnd Bergmann wrote:
> disappears, and it also goes away if I disable inlining that function:

Yes, makes sense. The state objtool tracks is strictly per function.

And I suppose GCC-10 just changed around the inline heuristc a bit and
we got lucky.

> --- a/lib/locking-selftest.c
> +++ b/lib/locking-selftest.c
> @@ -1134,7 +1134,7 @@ static int testcase_successes;
>  static int expected_testcase_failures;
>  static int unexpected_testcase_failures;
> 
> -static void dotest(void (*testcase_fn)(void), int expected, int lockclass_mask)
> +static noinline void dotest(void (*testcase_fn)(void), int expected,
> int lockclass_mask)
>  {
>         unsigned long saved_preempt_count = preempt_count();
> 
>     Arnd