Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp897431ybz; Fri, 1 May 2020 10:31:42 -0700 (PDT) X-Google-Smtp-Source: APiQypKjhcSHnrCzQT/uACB6BJ/Y6YdPwS5ds8LcHpudWseV+KvpJET1M3PQTP3hfOx7c9vZkMgX X-Received: by 2002:aa7:dcd4:: with SMTP id w20mr4633254edu.282.1588354302400; Fri, 01 May 2020 10:31:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588354302; cv=none; d=google.com; s=arc-20160816; b=u1cVtv/61KY2cJawHld3rCAJE8Oh9u0ceaNW9t3augWySD+KsK6hvWc6oi3HEHFVpS iMFQ2xJgr/QqIlx62dwndXKL7yLEnKPL+byh/pxx058ONl+rY5JDbReemG5W8mJDlG+B YuQ/m5exRg8D7NOCcyTnLnjIPpe/umHF9A1ChmvtE1Bxb7GdyyVWSh/nvpYOu8VSjbzo 653vv+Ww/9zNMpyVH/po+WgGCNsABpZ3xezaj1X1CSMODlsWDv2nwf5D2enwDxeNKMtm RXtv8I+VjYJ6F++zlCBq9GYqEB8q7YoJ+3Ov9eyMoQbhhKjytqBBWU2NbcjD236UM8IF jIaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VmepliU6UQehgsmulQ6adsZNqvXtAi0vjXnXPofRBXc=; b=R+dExouYqhk6tDpFEEEc9dtjYm2cEEqUC4E/rpw4hysMkLykrINDnQw/06GWupPGBR Jh7q0UtOdZT1XtWldFYGhl/xRwwrWKTDfQy2UzoopBQm+rYON4xjpEsUFoIs0gHbmuYD n8dPRp2yP1HLxPG6bJBCB+sqXuuNJJ09Qy/mBakHg+v7n+FOOZ58131yGYHJ+ZQMwyum bS8/7fDUDYYthzj9qXl2UDd3GTYSg1iiJ/l6NXSP/MFYa4giR6JOasTPMJx76o1HBeHT yPAYOV6My2TZAi+pqQN+AcvrqtDo9kggq7t8pyUa5+xAGACahaYucShST1waZIAxJn57 c5aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g7si1800779ejf.410.2020.05.01.10.31.17; Fri, 01 May 2020 10:31:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729847AbgEAR0z (ORCPT + 99 others); Fri, 1 May 2020 13:26:55 -0400 Received: from verein.lst.de ([213.95.11.211]:47959 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728933AbgEAR0z (ORCPT ); Fri, 1 May 2020 13:26:55 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6FA7B68C65; Fri, 1 May 2020 19:26:53 +0200 (CEST) Date: Fri, 1 May 2020 19:26:53 +0200 From: Christoph Hellwig To: Martijn Coenen Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, narayan@google.com, zezeozue@google.com, kernel-team@android.com, maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com, jaegeuk@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 02/10] loop: Factor out setting loop device size Message-ID: <20200501172653.GB22792@lst.de> References: <20200429140341.13294-1-maco@android.com> <20200429140341.13294-3-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429140341.13294-3-maco@android.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 04:03:33PM +0200, Martijn Coenen wrote: > This code is used repeatedly. > > Signed-off-by: Martijn Coenen > --- > drivers/block/loop.c | 31 ++++++++++++++++++++++--------- > 1 file changed, 22 insertions(+), 9 deletions(-) Looks good: Reviewed-by: Christoph Hellwig