Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 May 2020 23:00:38 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Konrad Dybcio <konradybcio@gmail.com>
Cc:     skrzynka@konradybcio.pl, Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Add support for TM5P5 NT35596 video mode panel
Message-ID: <20200501210038.GB26726@ravnborg.org>
References: <20200501204825.146424-1-konradybcio@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200501204825.146424-1-konradybcio@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Konrad.

On Fri, May 01, 2020 at 10:48:21PM +0200, Konrad Dybcio wrote:
> I am aware of the fact that this is probably not the correct
> naming of this panel, yet I am unable to retrieve any additional
> information about it, as it is used in a smartphone to which no
> schematics are released.
> 
> The driver has been generated with the help of 
> linux-mdss-dsi-panel-driver-generator [1] and works perfectly
> on a Asus Zenfone 2 Laser Z00T smartphone, including brighness
> control and switching on/off.
> 
> [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator

Panle driver looks good.
Will take a closer look tomorrow.

Any chance you can work on the TODO in the driver so we can have that
resolved before we apply it?

Also for a v2 it would be perfect if you could work on top of
drm-misc-next.
There is at least one small fix needed to build that I spotted.

But wait until I get back on the driver patch before submitting a v2.

	Sam

> 
> Konrad Dybcio (2):
>   drivers: drm: panel: Add TM5P5 NT35596 panel driver
>   dt-bindings: display: Document TM5P5 NT35596 panel compatible
> 
>  .../bindings/display/panel/tm5p5,nt35596.txt  |   7 +
>  drivers/gpu/drm/panel/Kconfig                 |   9 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  drivers/gpu/drm/panel/panel-tm5p5-nt35596.c   | 366 ++++++++++++++++++
>  4 files changed, 383 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/tm5p5,nt35596.txt
>  create mode 100644 drivers/gpu/drm/panel/panel-tm5p5-nt35596.c
> 
> -- 
> 2.26.1