Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1080578ybz; Fri, 1 May 2020 14:08:35 -0700 (PDT) X-Google-Smtp-Source: APiQypI8Vyotfp813GVPSuJIbvfyWRtKSbNhbg9DpiURVFySLUKwHd7d6SxTP1t6B3nYO8pmMrR8 X-Received: by 2002:a17:906:4ed6:: with SMTP id i22mr5215446ejv.146.1588367315565; Fri, 01 May 2020 14:08:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588367315; cv=none; d=google.com; s=arc-20160816; b=C+pvWBURhasLPEu78tUCKQ3qCMMxKBUUljU+n5JjlUitzXq+6XiWdp1nlOgbk2RBLV R+dtKNE9gvKM9PsVBiBlJ+om2wYdLMqx6ZhK8VFMRu0h5b83tNWBGgaXTCzxrIxQWw8u zOwkNCs0p/bJNEHjWO7fJGs/mdEBURN8Uthsw7GNW4fK+IKNaeUAab0PU9u2Kt8anxCq teQpZMj2Zi29IdljNj675YBPWxC67fmTNGvIeFjs3W2sAdRMkrs9GKke4GSHcr3jdRDr 0rcqQxyK946oUporhLH9Q3WtO0FPldHto+wwb5/F4q1tE8MRLQ+YQ9M0YYiG2iuKGh+K TZEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:from:cc:to:subject :ironport-sdr:ironport-sdr; bh=RTSuiL7Y8NdfKHp3nYMWNOWrCi2E3oL8gJ9imUG/iZQ=; b=PdGlRLW9al8jE5Nr1/blS4tFdZ0SPUHxSXBSq+AOgq0mwvlTfK4g2PRp5ruq3EP177 PKq60bKb7uw2rHCC1q/Jn5E23DKIY7nxj+p8zS2TUIuM0Qkno+phIYZk4bMDfpgnzUij pNE83t5BlQc/oaLHcXxFjFKGmH3HtP6jeIqenKaUUnAdrnBpIb3m3SRK8jvtjwqHDI6/ iqDvu9CuQ1rq2uuYi59gSwoCcNQ3k0cO5JRr1Nf+XTC+Lr2ew1Y9AQZmAqnwcZ/255j7 TojewXqjN/jMG8p54xAL5cwbScouRr5ceb2gJOL9iPNi8JajNvT1bVW69zG6JVRpMNl1 vKtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si2348486edb.221.2020.05.01.14.08.13; Fri, 01 May 2020 14:08:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726486AbgEAVGz (ORCPT + 99 others); Fri, 1 May 2020 17:06:55 -0400 Received: from mga05.intel.com ([192.55.52.43]:3274 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbgEAVGz (ORCPT ); Fri, 1 May 2020 17:06:55 -0400 IronPort-SDR: XEq9ZBGISbmFdDu5TEvcsyEMctO/Sck3agWk6mzjJ6rjyxhmZQqOV5N2L8NH+19D77r9wxDIY0 Fmm0mJDxZbzQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2020 14:06:54 -0700 IronPort-SDR: t2PqYLdbKCc7wr0GW+Q1DcVZcCRz7MTrjlU96aXv/GRzvAc4vieAEvX6CJuFmCThNzQuhVVW5z c9NusSaHCRow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,341,1583222400"; d="scan'208";a="283291765" Received: from viggo.jf.intel.com (HELO localhost.localdomain) ([10.54.77.144]) by fmsmga004.fm.intel.com with ESMTP; 01 May 2020 14:06:54 -0700 Subject: [RFC][PATCH 0/2] mm: tweak page cache migration To: linux-kernel@vger.kernel.org Cc: Dave Hansen , npiggin@gmail.com, akpm@linux-foundation.org, willy@infradead.org, yang.shi@linux.alibaba.com, linux-mm@kvack.org From: Dave Hansen Date: Fri, 01 May 2020 14:05:16 -0700 Message-Id: <20200501210516.DFAFF456@viggo.jf.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org First of all, I think this little slice of code is a bit under-documented. Perhaps this will help clarify things. I'm pretty confident the page_count() check in the first patch is right, which is why I removed it outright. The xas_load() check is a bit murkier, so I just left a warning in for it. Cc: Nicholas Piggin Cc: Andrew Morton Cc: Matthew Wilcox (Oracle) Cc: Yang Shi Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org