Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH] mm: slub: add panic_on_error to the debug facilities
From:   Qian Cai <cai@lca.pw>
In-Reply-To: <20200501211540.71216-1-aquini@redhat.com>
Date:   Fri, 1 May 2020 17:29:19 -0400
Cc:     Linux-MM <linux-mm@kvack.org>, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, iamjoonsoo.kim@lge.com,
        rientjes@google.com, penberg@kernel.org, cl@linux.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <21CF143C-B9D1-4D3F-A875-370924265593@lca.pw>
References: <20200501211540.71216-1-aquini@redhat.com>
To:     Rafael Aquini <aquini@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On May 1, 2020, at 5:15 PM, Rafael Aquini <aquini@redhat.com> wrote:
>=20
> Sometimes it is desirable to override SLUB's debug facilities
> default behavior upon stumbling on a cache or object error
> and just stop the execution in order to grab a coredump, at
> the error-spotting time, instead of trying to fix the issue
> and report in an attempt to keep the system rolling.
>=20
> This patch introduces a new debug flag SLAB_PANIC_ON_ERROR,
> along with its related SLUB-machinery, in order to extend
> current slub_debug facilites and provide the aforementioned
> behavior override.

Instead of adding those things everywhere. How about adding something =
like panic_on_taint? Then, you could write specific taint flags you are =
interested in to that file because slab_bug() will taint it =
TAINT_BAD_PAGE.=