Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1132580ybz; Fri, 1 May 2020 15:20:45 -0700 (PDT) X-Google-Smtp-Source: APiQypJExHq78AR6MTOr+CAAOr8HphpDj5wbfp34dv48VHa1Br8blByHjK3yZurS6esoPzCkEGxA X-Received: by 2002:a50:c487:: with SMTP id y7mr5397993edf.312.1588371645784; Fri, 01 May 2020 15:20:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588371645; cv=none; d=google.com; s=arc-20160816; b=W/R7VXl8xOcWcgM8Qiq94z5biaaPBrfvivx7wFVibUSpkJ5WWw3CjssFzlGbGxow+g ZNyzaSegW9w7aen+GKdspn5ozBsdqjz04pt5zAFyQHMc+yNR/cZWPdue8iTu1lkeJZ5Z ALrJHTRrOzhy5auxxzltcll5yOsH8sIuNbx30uNBqOuJGVmPdgjZ6ZiPuIKfaKtILaI1 eb+C1LclT9Myy9dXtJjbkNBUAzbzRO8YPj7rNcIaNXnuAvS+Ny9O1qz6S4U0/sY9E9XX pGQsNifxZLrQ2bM/My7wU5Q9HV4fTlUBeUwScs/nMkZuCIO8GF3qDQDG5bPB6oVEkcTV uRxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=cQpoyHNCKar6ZGfYw/JVeq7Gq/wjyHQEcHJjZyc70e0=; b=T7sf/nICk4Jq3Ojfr1zk3gUcV2ebi4mCYSQ6UyiyFG0IB5awaL8GkmQMNCFeDotQjQ 3+qJrDBpP2coUXe0vewadlcu3Wza9/wSqjerGqyRKOgsV6smJl39G0CjLsvLGIpM9Moi +1K7ll8XVq1mcqiT5L5AymTsDTntaihO8iKJuxnFYxxrK9G8ieccMiua/2A7fjNOGBX0 mjqEYLBL5xqWVDFCMEBqfmZp0oh52lH3lxFnCDEXArRajMztNR2WdhMs/axeGQzIJ4xW D4hbb6nC4bLr/YDD7K17hl3+L0lAqYJQXx7sATGtBW0EGMGCP1+tdB5CzTCSY3jQnDPo mZiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=lwyWH8eU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oq26si2758204ejb.105.2020.05.01.15.20.22; Fri, 01 May 2020 15:20:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=lwyWH8eU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbgEAWQb (ORCPT + 99 others); Fri, 1 May 2020 18:16:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbgEAWQb (ORCPT ); Fri, 1 May 2020 18:16:31 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29C11C061A0C; Fri, 1 May 2020 15:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cQpoyHNCKar6ZGfYw/JVeq7Gq/wjyHQEcHJjZyc70e0=; b=lwyWH8eUA9yp/PjFEZ0fOXMz32 W+3BVOGRKPxbCZVFpFcKFZ/YxhVhWKlpaBnzQ28JUrmpYm+VEr/9CTnOSTiVVPdxDFWeXyVSfQH6e QoRe2erhHBOe4Qxt5tmP6xoRX48PSfw61DOGEX/2n5cqzekCtVJ0vLT7apga4kvNWxZwz0hG6qdxw UAyCSMKEg/xFrkznY8/Tr/B8+lMaO0Jr1S1NqI8zddcQNfMX3crNmRhs4lvMxiXZkY6s7lGmp1s8S l/n+eGhY40oSiw6AROzmD2WuUoF6ZqdshEkyUFSey/HZ2LxrDnJd+dW3S6vjXjD1jvxF8iNptuhMX aRWYV7qQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUdxK-0003xq-Cv; Fri, 01 May 2020 22:16:26 +0000 Date: Fri, 1 May 2020 15:16:26 -0700 From: Matthew Wilcox To: Guoqing Jiang Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, david@fromorbit.com Subject: Re: [RFC PATCH V2 0/9] Introduce attach/clear_page_private to cleanup code Message-ID: <20200501221626.GC29705@bombadil.infradead.org> References: <20200430214450.10662-1-guoqing.jiang@cloud.ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430214450.10662-1-guoqing.jiang@cloud.ionos.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2020 at 11:44:41PM +0200, Guoqing Jiang wrote: > include/linux/pagemap.h: introduce attach/clear_page_private > md: remove __clear_page_buffers and use attach/clear_page_private > btrfs: use attach/clear_page_private > fs/buffer.c: use attach/clear_page_private > f2fs: use attach/clear_page_private > iomap: use attach/clear_page_private > ntfs: replace attach_page_buffers with attach_page_private > orangefs: use attach/clear_page_private > buffer_head.h: remove attach_page_buffers I think mm/migrate.c could also use this: ClearPagePrivate(page); set_page_private(newpage, page_private(page)); set_page_private(page, 0); put_page(page); get_page(newpage);