Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 May 2020 18:04:17 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc:     Joe Perches <joe@perches.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: add NL_SET_ERR_MSG to 80 column exceptions
Message-ID: <20200501180417.09bcb6e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <02874ECE860811409154E81DA85FBB58C0774F94@ORSMSX151.amr.corp.intel.com>
References: <20200501231131.2389319-1-jacob.e.keller@intel.com>
        <e1e12e3f6992c00c005ba2b3bcf671c033a1dccc.camel@perches.com>
        <5a1da586-0cc0-1900-477f-6fef61af7f95@intel.com>
        <1c86e75bb56693bc2343d30e5baba09c783b02a2.camel@perches.com>
        <02874ECE860811409154E81DA85FBB58C0774F94@ORSMSX151.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2 May 2020 00:36:48 +0000 Keller, Jacob E wrote:
> > The ones I specified previously use:
> > 
> > 	NL_SET_ERR_MSG_MOD(extack, "message\n");
> > 
> > where all the others uses are:
> > 
> > 	NL_SET_ERR_MSG_MOD(extack, "message");
> > 
> > without the \n termination of the message.
> >   
> 
> I see. Yea, I think the trailing newline isn't needed, but I'm not sure.

Yup, there should be no new line at the end of an extack message.