Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1470174ybz; Sat, 2 May 2020 00:21:09 -0700 (PDT) X-Google-Smtp-Source: APiQypLSZpP2nAXvEmB87C62VZ1B0mR7zPHEklekCIPSd5Ue+oblkz0r6Pw8zCGZiuH3YhUfJfK1 X-Received: by 2002:a17:906:4ecd:: with SMTP id i13mr6495866ejv.68.1588404069731; Sat, 02 May 2020 00:21:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588404069; cv=none; d=google.com; s=arc-20160816; b=D3s9T4231D7iOVXXm9Unvn+vyRHS1Xhy4+SfHAwnX66NqrpUwEDqB54F/8rJ7w++rB n4j9HsoI+0cfpQtt/TaronTZLclpBUakylvmziE4YZaFIpNPtBeE+plTjd0yfkpaHSm3 XHBfYKOwTVvWJLXvRRX8GL+Jan4ZYxbCAFnFPWAXHpcjRAbmRyQ5kfauYcgDID+qYrts SHfD0eIEzOKVkP6UVGMdtzyMv+OrkkNi8l1jgeJV1x+PUU303ZbrHgcNeXWxUkhKQB7P ADjy17WXNjK9hD95fA+u+2SiJzuBX8F98H5Qi+lWDlQAtIRLHNSUqepPGdX1IcJ+XQL4 SNcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=s5uhpssjkwOgvIOOAiiAqewYZtJeWdwM1aD3T+GvXnc=; b=GVM3nF22HlcBwP1NhlVSGg9fQYK1XWjoE4fYdsqys+3+HyLp1YV70a70KYcAlF227p K+bV6BxxrSCppgRdEwMogHIruVFgVg5Cdhgy6tLFgVxk34VaUlS9u+2PX0Jp7gtB5U/E gv272DdRoKMG3fZQTqIk7OpHEPRZPjLLovlAjp1tiMrFstr19G8x2hXmyjeOu5xbyfsW naG0azILEjacYHcZeL4wqiYG67NzBRkS+SHfsplJ1K19hEKvgKOUVuZSAO0te3jgiy+d x+R8McxL8IJzP8pxKP2/6FzFzWX8RluL3S8exs1ZqH8igdtWH4e+LeiK/lRYxHIPfxVG 3svQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u1si2981991edi.58.2020.05.02.00.20.46; Sat, 02 May 2020 00:21:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726654AbgEBHRb (ORCPT + 99 others); Sat, 2 May 2020 03:17:31 -0400 Received: from bmailout3.hostsharing.net ([176.9.242.62]:45865 "EHLO bmailout3.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbgEBHRb (ORCPT ); Sat, 2 May 2020 03:17:31 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 4BDD71003CE02; Sat, 2 May 2020 09:17:29 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id B7EEC3F76B2; Sat, 2 May 2020 09:17:28 +0200 (CEST) Date: Sat, 2 May 2020 09:17:28 +0200 From: Lukas Wunner To: Takashi Iwai Cc: Nicholas Johnson , Alex Deucher , "Zhou, David(ChunMing)" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Takashi Iwai , "Deucher, Alexander" , "Koenig, Christian" Subject: Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state Message-ID: <20200502071728.fn2fcqvt6aies3zu@wunner.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -673,6 +673,12 @@ static int amdgpu_dm_audio_component_bind(struct device *kdev, > struct amdgpu_device *adev = dev->dev_private; > struct drm_audio_component *acomp = data; > > + if (!device_link_add(hda_kdev, kdev, DL_FLAG_STATELESS | > + DL_FLAG_PM_RUNTIME)) { > + DRM_ERROR("DM: cannot add device link to audio device\n"); > + return -ENOMEM; > + } > + Doesn't this duplicate drivers/pci/quirks.c:quirk_gpu_hda() ?