Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1588370065-30312-1-git-send-email-sidgup@codeaurora.org>
In-Reply-To: <1588370065-30312-1-git-send-email-sidgup@codeaurora.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun, 3 May 2020 00:03:26 +0900
Message-ID: <CAK7LNARPH+hZdo-0_pmOzZNqTHj7rJTMQq9Nd_F-oyqK2zJrtQ@mail.gmail.com>
Subject: Re: [PATCH] scripts: headers_install: Exit with error on config leak
To:     Siddharth Gupta <sidgup@codeaurora.org>
Cc:     Sam Ravnborg <sam@ravnborg.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, May 2, 2020 at 6:55 AM Siddharth Gupta <sidgup@codeaurora.org> wrote:
>
> Misuse of CONFIG_* in UAPI headers should result in an error as it exposes
> configuration of different targets to userspace.
>
> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
> ---
>  scripts/headers_install.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh
> index a07668a..bd6c93a 100755
> --- a/scripts/headers_install.sh
> +++ b/scripts/headers_install.sh
> @@ -109,7 +109,8 @@ do
>         done
>
>         if [ "$warn" = 1 ]; then
> -               echo "warning: $INFILE: leak $c to user-space" >&2
> +               echo "error: $INFILE: leak $c to user-space" >&2
> +               exit 1
>         fi
>  done


If you want to change this,
please update the comment at line 67.

Also, rename the variable $warn to
something else, $error or $leak_error, etc. ?


-- 
Best Regards
Masahiro Yamada