Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 2 May 2020 15:03:54 -0400
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Syed Nayyar Waris <syednwaris@gmail.com>
Cc:     akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
        linus.walleij@linaro.org, bgolaszewski@baylibre.com,
        michal.simek@xilinx.com, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] gpio: xilinx: Utilize for_each_set_clump macro
Message-ID: <20200502190354.GA6513@shinobu>
References: <cover.1588443578.git.syednwaris@gmail.com>
 <366a64f80ee9fe1c644ea038ac112ead9766d5c8.1588443578.git.syednwaris@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6"
Content-Disposition: inline
In-Reply-To: <366a64f80ee9fe1c644ea038ac112ead9766d5c8.1588443578.git.syednwaris@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--y0ulUmNC+osPPQO6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, May 03, 2020 at 12:21:54AM +0530, Syed Nayyar Waris wrote:
> This patch reimplements the xgpio_set_multiple function in
> drivers/gpio/gpio-xilinx.c to use the new for_each_set_clump macro.
> Instead of looping for each bit in xgpio_set_multiple
> function, now we can check each channel at a time and save cycles.
>=20
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
> Changes in v4:
>  - Minor change: Hardcode value for better code readability.
>=20
> Changes in v3:
>  - No change.
>=20
> Changes in v2:
>  - No change.
>=20
>  drivers/gpio/gpio-xilinx.c | 64 ++++++++++++++++++++------------------
>  1 file changed, 34 insertions(+), 30 deletions(-)
>=20
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 67f9f82e0db0..67c5eeaf1bb9 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -136,39 +136,43 @@ static void xgpio_set(struct gpio_chip *gc, unsigne=
d int gpio, int val)
>  static void xgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
>  			       unsigned long *bits)
>  {
> -	unsigned long flags;
> +	unsigned long flags[2];
>  	struct xgpio_instance *chip =3D gpiochip_get_data(gc);
> -	int index =3D xgpio_index(chip, 0);
> -	int offset, i;
> -
> -	spin_lock_irqsave(&chip->gpio_lock[index], flags);
> -
> -	/* Write to GPIO signals */
> -	for (i =3D 0; i < gc->ngpio; i++) {
> -		if (*mask =3D=3D 0)
> -			break;
> -		/* Once finished with an index write it out to the register */
> -		if (index !=3D  xgpio_index(chip, i)) {
> -			xgpio_writereg(chip->regs + XGPIO_DATA_OFFSET +
> -				       index * XGPIO_CHANNEL_OFFSET,
> -				       chip->gpio_state[index]);
> -			spin_unlock_irqrestore(&chip->gpio_lock[index], flags);
> -			index =3D  xgpio_index(chip, i);
> -			spin_lock_irqsave(&chip->gpio_lock[index], flags);
> -		}
> -		if (__test_and_clear_bit(i, mask)) {
> -			offset =3D  xgpio_offset(chip, i);
> -			if (test_bit(i, bits))
> -				chip->gpio_state[index] |=3D BIT(offset);
> -			else
> -				chip->gpio_state[index] &=3D ~BIT(offset);
> -		}
> +	u32 *const state =3D chip->gpio_state;
> +	unsigned int *const width =3D chip->gpio_width;
> +	const unsigned long state_size =3D 32;
> +	const unsigned long total_state_bits =3D state_size * 2;

Hello Syed,

I don't think there's much need for these two variables either. You can
remove the state_size and total_state_bits variables, and instead inline
32 and 64 directly in your code below.

William Breathitt Gray

> +	unsigned long offset, clump;
> +	size_t index;
> +
> +	DECLARE_BITMAP(old, 64);
> +	DECLARE_BITMAP(new, 64);
> +	DECLARE_BITMAP(changed, 64);
> +
> +	spin_lock_irqsave(&chip->gpio_lock[0], flags[0]);
> +	spin_lock_irqsave(&chip->gpio_lock[1], flags[1]);
> +
> +	bitmap_set_value(old, state[0], 0, width[0]);
> +	bitmap_set_value(old, state[1], width[0], width[1]);
> +	bitmap_replace(new, old, bits, mask, gc->ngpio);
> +
> +	bitmap_set_value(old, state[0], 0, state_size);
> +	bitmap_set_value(old, state[1], state_size, state_size);
> +	state[0] =3D bitmap_get_value(new, 0, width[0]);
> +	state[1] =3D bitmap_get_value(new, width[0], width[1]);
> +	bitmap_set_value(new, state[0], 0, state_size);
> +	bitmap_set_value(new, state[1], state_size, state_size);
> +	bitmap_xor(changed, old, new, total_state_bits);
> +
> +	for_each_set_clump(offset, clump, changed, total_state_bits, state_size=
) {
> +		index =3D offset / state_size;
> +		xgpio_writereg(chip->regs + XGPIO_DATA_OFFSET +
> +				index * XGPIO_CHANNEL_OFFSET,
> +				state[index]);
>  	}
> =20
> -	xgpio_writereg(chip->regs + XGPIO_DATA_OFFSET +
> -		       index * XGPIO_CHANNEL_OFFSET, chip->gpio_state[index]);
> -
> -	spin_unlock_irqrestore(&chip->gpio_lock[index], flags);
> +	spin_unlock_irqrestore(&chip->gpio_lock[1], flags[1]);
> +	spin_unlock_irqrestore(&chip->gpio_lock[0], flags[0]);
>  }
> =20
>  /**
> --=20
> 2.26.2
>=20

--y0ulUmNC+osPPQO6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl6tw/0ACgkQhvpINdm7
VJILNxAAizO1hWD+T2Ay9Zlch1hjNpo3iqmseCGBISXOB6SsfaYr0KwfbEpzxbHb
pqVfmPg7JqG/CUiEeXPX74QnAL4aLSRUQXO+Sbm0uPMxcl8mPwsmHhyVqrd0+iJi
lB0boE968Hatex9T6PUOe5O97BvNPOBqL9Us66+ji1Iexrq/4n0KykRSyhrQegFE
h3j5YkrfxgPxYePfDnn+wj5zsA8pgMcfGVFAuDI2jQi/S8px+Z2/NRDQSF8rFB7b
nChHKmhMscEqbChCuFsIOO6Rg65nwTIsDUQbCdFhhruAj8Q1v2fqkbEmTGQiu/nz
luKwt5mphkRoTCZLscYSZBhIjaq+xv14rM9Qn4nDtpun/PH4QRH0/PkJf2eaarJy
M1dMHEvS7vDwTx17YUXcXJy0qfVeBsPgTZxcOtTawO51+JmSPwSGpmvFA9wHb7iA
uT15Ba3IcR66z6nDJkMyzVNVRtZoTEEP200LBzYXvrCOIgypykRBn3edFshct2qo
Yup1vzFG69Z/PtninV3tei5QAqnwWkfyBgnzTUiCa57aPM026uxcoDABHbYDnkxk
WwtWn61px3tW5dRYrpxkgWyQ9YBfTfynQNldh2Ls+Kb+Mka1jIi1UqtTfNJdM73w
T7tYHxdR8b2X0qu3qxWW279D6RP1ied04gqzsfPdMa0RmMxMSe4=
=aFyG
-----END PGP SIGNATURE-----

--y0ulUmNC+osPPQO6--