Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: gcAiNTKGQvTo6w2jhuZktK9xd7rXB5qROA9ZkUlThHVGFh9T6CKi0TplxJj7netc5OUGqZyB3S
 AvS3cDl6w73yVmACIpghblhYhp+CKD/1XJeayjRiOliAnpAIlqos3TYztKPz2rMWRegoFCpKd6
 ltKeMGB1RWvpSLxvkEVb4q+RBwTlFzYhkRVi6Vu3q1ArVQPU0p+Cq2yki/3JVFDbu7xGL+Tcq+
 z86abJmjOtjZvyg5B9EngROlVfrggdkPGSM4f3dclxzbx+jwmzOzrYLUQ+OSORlBu2SGS9j+M1
 qFI=
From:   <Nicolas.Ferre@microchip.com>
To:     <zhengdejin5@gmail.com>, <davem@davemloft.net>,
        <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <yash.shah@sifive.com>, <netdev@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <andy.shevchenko@gmail.com>
Subject: Re: [PATCH net v3] net: macb: fix an issue about leak related system
 resources
Thread-Topic: [PATCH net v3] net: macb: fix an issue about leak related system
 resources
Thread-Index: AQHWIVvYggk+vhGn+kWhokMBzi8iag==
Date:   Sun, 3 May 2020 15:02:20 +0000
Message-ID: <d414cfd2-f0c8-313b-1a4e-fe90a287a318@microchip.com>
References: <20200503123226.7092-1-zhengdejin5@gmail.com>
In-Reply-To: <20200503123226.7092-1-zhengdejin5@gmail.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <088385B4C62AA44FBAE0D3F8507A5977@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c958684-b1d5-4da7-f6ac-08d7ef72fb0a
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2020 15:02:21.0046
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nbXYyGsBtMhRMlERHe2ZRgYRW2vtrCF3aODdgHk3CVsCmx0p2OaUvoKCUw+q88KplxlPTgDErnsQV2hmkAQPAAunQiVoKSZWl6Zxst9U0ek=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2893
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/05/2020 at 14:32, Dejin Zheng wrote:
> A call of the function macb_init() can fail in the function
> fu540_c000_init. The related system resources were not released
> then. use devm_platform_ioremap_resource() to replace ioremap()
> to fix it.
>=20
> Fixes: c218ad559020ff9 ("macb: Add support for SiFive FU540-C000")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Yash Shah <yash.shah@sifive.com>
> Suggested-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---
> v2 -> v3:
>          - use IS_ERR() and PTR_ERR() for error handling by Nicolas's
>            suggestion. Thanks Nicolas!
> v1 -> v2:
>          - Nicolas and Andy suggest use devm_platform_ioremap_resource()
>            to repalce devm_ioremap() to fix this issue. Thanks Nicolas
>            and Andy.
>          - Yash help me to review this patch, Thanks Yash!
>=20
>   drivers/net/ethernet/cadence/macb_main.c | 12 +++---------
>   1 file changed, 3 insertions(+), 9 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ether=
net/cadence/macb_main.c
> index a0e8c5bbabc0..f040a36d6e54 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4172,15 +4172,9 @@ static int fu540_c000_clk_init(struct platform_dev=
ice *pdev, struct clk **pclk,
>=20
>   static int fu540_c000_init(struct platform_device *pdev)
>   {
> -       struct resource *res;
> -
> -       res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -       if (!res)
> -               return -ENODEV;
> -
> -       mgmt->reg =3D ioremap(res->start, resource_size(res));
> -       if (!mgmt->reg)
> -               return -ENOMEM;
> +       mgmt->reg =3D devm_platform_ioremap_resource(pdev, 1);
> +       if (IS_ERR(mgmt->reg))
> +               return PTR_ERR(mgmt->reg);
>=20
>          return macb_init(pdev);
>   }
> --
> 2.25.0
>=20


--=20
Nicolas Ferre