Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2751071ybz; Sun, 3 May 2020 08:27:25 -0700 (PDT) X-Google-Smtp-Source: APiQypI+tQHVKqCnHfc+tfKWppGEyo/lBO0WCP10MmuoE9FvrXUA8RzhCf7pf/2w9aczoXa26LrR X-Received: by 2002:a17:906:4317:: with SMTP id j23mr11096650ejm.377.1588519645397; Sun, 03 May 2020 08:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588519645; cv=none; d=google.com; s=arc-20160816; b=lauokn/6o69ODiklLRRWwGa9zbeulyfMnmUBWHG3jaFRziFmDuRjHKQNb3VwIiofg+ aUzMJ0nGI5QhbAs/vtbscQz6bSCwxUEBMaJDvxUE3qewn2Ae4hAX7Ifp+iVJNNddRfFz QVIqOMyNQ3GAWtUYsVCbo+scbFeo2AUc550LVnWxQo1geTvhuNCgWusekyKA4w05JVHf gr7gbGa7PWjA9ewiWNbSWylI2OqXekwvnycuAKDpRHqm3NddKeOWqWUrAYWWPbSlgvpD PIr6O0tpiStRurYyneEWpuwefrx7eVDA0nDZIQrMWYMhYrqcvRBVb8SthiB2h+nsVnpx wiBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=KtJ8gZii1X9I3cudCEP1uS163ZciLf3o1TikA/PlHMg=; b=DgR6ZLQs+ZsYIrY/YTIgaPy2ZvERs90f9mgMFfA4+P95J3tBWMWTx9JYEykHRJ/76S 42lM5H2ZcT5irt/S6PGZfAhrChhUgQtn7e4biqX/+cqGseNYV6r4FsSA+xXeRg4+C03s FdDB0euXgOse6cQ4BbLF77rLRd3tRWJ7lnnxYSUGB0TRyvBU/stGseljP6TlNSj1ueTa nSHwYq7YlHdszRPI9JOdncZmKpkh37txDCP7JRZc/OxLgL1HRn/2i4bRrsfWH+VPo7aM L7PTwHtFloexrsUPbmQz74q9pyC4/JzCil4DuyiIy2GQjaysMehgJzRmbqT0k94e32t+ 4gLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v25si5281030ejx.386.2020.05.03.08.27.03; Sun, 03 May 2020 08:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728752AbgECPZU (ORCPT + 99 others); Sun, 3 May 2020 11:25:20 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36640 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728713AbgECPZT (ORCPT ); Sun, 3 May 2020 11:25:19 -0400 Received: from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jVGUF-0004b3-Ls; Sun, 03 May 2020 15:25:00 +0000 From: Kai-Heng Feng To: tiwai@suse.com Cc: David_chen7@dell.com, Kai-Heng Feng , Jaroslav Kysela , Kailang Yang , Hui Wang , Jian-Hong Pan , Tomas Espeleta , Thomas Hebb , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/2] Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Date: Sun, 3 May 2020 23:24:46 +0800 Message-Id: <20200503152449.22761-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757. Enable power save node breaks some systems with ACL225. Revert the patch and use a platform specific quirk for the original issue isntead. Fixes: 3b36b13d5e69 ("ALSA: hda/realtek: Fix pop noise on ALC225") BugLink: https://bugs.launchpad.net/bugs/1875916 Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index b26f0acfd86e..dedf0c17f198 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8246,8 +8246,6 @@ static int patch_alc269(struct hda_codec *codec) spec->gen.mixer_nid = 0; break; case 0x10ec0225: - codec->power_save_node = 1; - /* fall through */ case 0x10ec0295: case 0x10ec0299: spec->codec_variant = ALC269_TYPE_ALC225; -- 2.17.1