Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200503131021.16575-1-aishwaryarj100@gmail.com>
In-Reply-To: <20200503131021.16575-1-aishwaryarj100@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 3 May 2020 19:28:07 +0300
Message-ID: <CAHp75VcShqK2B4UdQXfi1nYa4fKkvdZE=d1O=w4QmrFk5Rb=+w@mail.gmail.com>
Subject: Re: [PATCH] i2c: img-scb: Use devm_platform_ioremap_resource and
 remove superfluous error message.
To:     Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
Cc:     Brendan Higgins <brendanhiggins@google.com>,
        Thor Thayer <thor.thayer@linux.intel.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Allison Randal <allison@lohutok.net>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, May 3, 2020 at 4:13 PM Aishwarya Ramakrishnan
<aishwaryarj100@gmail.com> wrote:
>
> Use the helper function that wraps the calls to
> platform_get_resource() and devm_ioremap_resource()
> together.
>
> The function platform_get_irq can log an error by itself.
> Omit a redundant message for exception handling in the
> calling function.
>
> Suggested by coccinelle.

Should be two patches, each of which with an explanation given. (And
of course you have to mention after cutter line '---' what kind of
tests you performed?)

-- 
With Best Regards,
Andy Shevchenko