Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2952900ybz; Sun, 3 May 2020 13:24:20 -0700 (PDT) X-Google-Smtp-Source: APiQypJDJJyHHwMzvoInJlKwx6ngsFROCOl+hIUt01V0mCKDZSL8WXPsPtBW/q9lw1nB05T+WUDd X-Received: by 2002:a17:907:9489:: with SMTP id dm9mr12691876ejc.9.1588537460595; Sun, 03 May 2020 13:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588537460; cv=none; d=google.com; s=arc-20160816; b=vmj6yBGr/rJnESe+g73iUd6qIoKcnhyQ48We/B0aKCnXKWFqH4fvrQpzIuYeKFNdGM hUQDQhZXnLHxq+G0Dwgrss1x7lDjhto1SIe42D/mxtsfd94KZLWuNeOWxLVUT/I7429I otaWqVapK42hfmQu/dOkxs+ByXkyLNMDqQ5bHYJCyOGbOat708J7Ix9gQZn7DMkj/5I9 Zvcdp25pBzxm3QNYHFO9EFNsu5dFmoDv5XnOv+harLeDZk96fBRTMmSebMogg9oZOqJe 58zC18LgPIU1znQeMbbB/f7/wuCiIp6mLN1gTnzCrM3iwEKiwgP/oWcQ8fXlN97zKkbH Aa2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:message-id:from:cc :subject:to:references:in-reply-to:content-transfer-encoding :mime-version; bh=8Cwt/i6jgillh/Ev1FnMn23yEtzFj0BvOOy+a9TOzIM=; b=FWhTtVbkVm87dEGa/8KJlEK2fL7Hf+hdl3uEL4fwa0mBGgAHGNzWnSqX/dhvD4RcFn JiddpmMmXjuMRVoawlOmH3G13GJDuAlAG1+YVWUfxNT6C77hhnu6/pNfcTb5kX8uTqTI E/xzCilENHvXGnYHfXm6n86HuboFx3SfAhe97okuXipFCjBtOeL1+Y/Cc8QraQ3GH9nJ McFfZuToAhdhsRAvSBmwKF3dI2MgYH6yY7IGYnR0Nh1Biby4gntMozx4JJrXKIex0ZZg SEGv4UzvwT4f0xCzP0Q+UbTZKPTofYCDXCePTBzlAtnr3TzLYA3VzG0E72ln0mw5tyfz C+pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id di2si5685699edb.117.2020.05.03.13.23.57; Sun, 03 May 2020 13:24:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729102AbgECUUY convert rfc822-to-8bit (ORCPT + 99 others); Sun, 3 May 2020 16:20:24 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:52747 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729080AbgECUUX (ORCPT ); Sun, 3 May 2020 16:20:23 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21101043-1500050 for multiple; Sun, 03 May 2020 21:20:21 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT In-Reply-To: <20200501180731.GA2485@infradead.org> References: <20200430221016.3866-1-Jason@zx2c4.com> <20200501180731.GA2485@infradead.org> To: "Jason A. Donenfeld" , Christoph Hellwig Subject: Re: [PATCH] drm/i915: check to see if SIMD registers are available before using SIMD Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, bigeasy@linutronix.de, tglx@linutronix.de, stable@vger.kernel.org From: Chris Wilson Message-ID: <158853721918.8377.18286963845226122104@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Sun, 03 May 2020 21:20:19 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Christoph Hellwig (2020-05-01 19:07:31) > On Thu, Apr 30, 2020 at 04:10:16PM -0600, Jason A. Donenfeld wrote: > > Sometimes it's not okay to use SIMD registers, the conditions for which > > have changed subtly from kernel release to kernel release. Usually the > > pattern is to check for may_use_simd() and then fallback to using > > something slower in the unlikely case SIMD registers aren't available. > > So, this patch fixes up i915's accelerated memcpy routines to fallback > > to boring memcpy if may_use_simd() is false. > > Err, why does i915 implements its own uncached memcpy instead of relying > on core functionality to start with? What is this core functionality that provides movntqda? -Chris