Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 04 May 2020 10:29:14 +0200
Message-ID: <s5ho8r4f6hx.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     <perex@perex.cz>, <tiwai@suse.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <linux-tegra@vger.kernel.org>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <sharadg@nvidia.com>, <mkumard@nvidia.com>,
        <viswanathl@nvidia.com>, <rlokhande@nvidia.com>,
        <dramesh@nvidia.com>, <atalambedu@nvidia.com>
Subject: Re: [PATCH 0/3] Tegra194 HW Fixes
In-Reply-To: <1588580176-2801-1-git-send-email-spujar@nvidia.com>
References: <1588580176-2801-1-git-send-email-spujar@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 04 May 2020 10:16:13 +0200,
Sameer Pujar wrote:
> 
> This series proposes SW workarounds for Tegra194 HDA HW bugs.
> Following are the two issues seen:
>  1. GCAP register does not reflect true capability.
>     The actual number of SDO lines is "4", where as it reflects "2".
>  2. With 4 SDO line configuration playback fails for,
>     44.1K/48K, 2-channel, 16-bps audio stream.
> 
> After fixing [1], issue [2] is uncovered.
> As per recommendation by Tegra HW team the workarounds are pushed.
> 
> Testing done
> ============
>  * Verify GCAP register after registering HDA sound card
>  * Verify audio playback for 44.1K/48K, 2-channel, 16-bps.
> 
> Sameer Pujar (3):
>   ALSA: hda/tegra: correct number of SDO lines for Tegra194
>   ALSA: hda: add member to store ratio for stripe control
>   ALSA: hda/tegra: workaround playback failure on Tegra194

Through a quick glance, all changes look good.

Is the device already in market, i.e. it had hit users?  If yes, I'm
going to merge for 5.7, otherwise for 5.8.


thanks,

Takashi