Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3536509ybz; Mon, 4 May 2020 05:03:56 -0700 (PDT) X-Google-Smtp-Source: APiQypKfd7R1HN9wp5vmttdGDGfuWs4OHysBQJzj7XZmGmkODm/kJkGUYAkDb8jK9AlqCDD8W8jS X-Received: by 2002:a17:906:38c:: with SMTP id b12mr14180135eja.332.1588593836088; Mon, 04 May 2020 05:03:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588593836; cv=none; d=google.com; s=arc-20160816; b=VCNYnZq3GfCkOI0aOUmJCDIJkhPRV/r2cq28Qv++eu33er6ywtJy6wMbptuou7iI5v yDABT7WVjAkDIpjqp7RggYsbvDEZeJ1Uvn5uONrDTZqq+5cuq0/Fvuw22P5LzbUK7plu WlH3fuu1REEsXxvtq8wULI3c/8DdnkGFwWWEIGtum0T1qbKkWpyBUPpQb+/Ly1XvTtHp C1DlNcd6w+h6BKphXLOPGzrk1eJcEyG1P8xgyKw6KM/uPXYmgtm0p1MM/Ge/0bmYEm8d MqyP275Ml+mSF6GkOzhjhfqUuvxDdygVN0m3HSbMRX+LJru/HBZ6ZuL5IhI/vZ8MqMyi 5Sqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QzsKXL54QvuRKs7TKdiKfQUShykoR6n5UojyFRWW+gk=; b=n25tpXVRdsuq2YeCWrkL0PGwxmHH596bST2vrPCP4ypug1aVE/PPJLlKV33zu+2X+1 X0IBKvEs2+2xRCqJZLj5k+cAL/EwgNClvdnuz9WfaExAZwjZr1jUh+SZdA73twuUJ5UB KgDGGk87njpn4WU7GsDfCCOSKRYFvcoE4mK4zsRvVCko+7jsyGPa6UAlhG8y5PuwkV1k RTxBCZkA6RVbuwdLOFRR414fWQqzejUHzh6I0tp5xkcbiNS/nElCNtCOhQnAS0fuUN2m EgpSpML1U1A0rN3Cwxlu7UHviG0cpNxInHc+pN5UyWIkteawrufC2cUAA3mKboRD0Lga SxKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="T/qK5uqm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v20si6377259edb.416.2020.05.04.05.03.31; Mon, 04 May 2020 05:03:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="T/qK5uqm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728695AbgEDMBf (ORCPT + 99 others); Mon, 4 May 2020 08:01:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726445AbgEDMBf (ORCPT ); Mon, 4 May 2020 08:01:35 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67F13C061A0E; Mon, 4 May 2020 05:01:35 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id hi11so3670311pjb.3; Mon, 04 May 2020 05:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QzsKXL54QvuRKs7TKdiKfQUShykoR6n5UojyFRWW+gk=; b=T/qK5uqmZIKrhIb/DIJ/DfL90hQm6GSUp/elWjJ8CwEU2qBhCwqivOba8xQgLRxeqV 4NThZBvi/6Q9PniGItMndipp+6FGGntmL7Mfw/1Sw10TUwVFfjOs7bsKcJIESRuqHZFj J2JAw3lzujhwppvKwyjnlDiFyaANCQ5/8UFNaIjLPFjDVYJ3lOagRm5Cn0x6O5465ZSU gJJcB8mmt0h3PEOy477BilIA4/OymYajsf5XzpM3lVvd2KFuucf+R2fpFlN2to8/cxgS LNs12AkViZlBjPjqtv6+/hIgXerlPQKrK09NswZR+cATPtZdSWUsIYphFWfcWC+r3GtM jH6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QzsKXL54QvuRKs7TKdiKfQUShykoR6n5UojyFRWW+gk=; b=k0DeWH8M9kxoNF8yjTZNEl5vI1go6Hw/8Lzi2Dk+HiWYCkJe5F2zMc0hJoOpJEWS7b NKb0hKGCrIGPPflztwXxai+kRhLcjDWjHnlQrK80GQkAocFj8rkOaFUVSjxFxNFI5GZQ +3stpvcHYbwknT4yneWZZKnyQcl7jJt0WN87MsMvkbbFYcMeAU3zkQF6i2GLXQRRWM1P 0/a8SZSzUFtTlk/0PEVwD0xo2tX2qN+SvItYZLS8fyphLWs7b/EP1uTmhma9Zn6c2QZB UngVV4nOofydXyPW/N2dV1X+ABRiIgdEQY8xkETr3DfTrVqP3HU6ATD9YU3FoiO1xE// qz/w== X-Gm-Message-State: AGi0PubOxrLlCU3ZK8UwnN0giw4Ihns5AK3IddhTKt8QlFdB/HcspQQy Sjc6tQ43Zz77DfzvX48umfk= X-Received: by 2002:a17:90a:3086:: with SMTP id h6mr17926601pjb.49.1588593694898; Mon, 04 May 2020 05:01:34 -0700 (PDT) Received: from localhost ([162.211.220.152]) by smtp.gmail.com with ESMTPSA id 14sm8945087pfj.90.2020.05.04.05.01.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 May 2020 05:01:34 -0700 (PDT) From: Dejin Zheng To: claudiu.manoil@nxp.com, davem@davemloft.net, vladimir.oltean@nxp.com, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Dejin Zheng , Andy Shevchenko Subject: [PATCH net v1] net: enetc: fix an issue about leak system resources Date: Mon, 4 May 2020 20:01:27 +0800 Message-Id: <20200504120127.4482-1-zhengdejin5@gmail.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org the related system resources were not released when enetc_hw_alloc() return error in the enetc_pci_mdio_probe(), add iounmap() for error handling label "err_hw_alloc" to fix it. Fixes: 6517798dd3432a ("enetc: Make MDIO accessors more generic and export to include/linux/fsl") Cc: Andy Shevchenko Signed-off-by: Dejin Zheng --- drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c index ebc635f8a4cc..15f37c5b8dc1 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c @@ -74,8 +74,8 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev, pci_disable_device(pdev); err_pci_enable: err_mdiobus_alloc: - iounmap(port_regs); err_hw_alloc: + iounmap(port_regs); err_ioremap: return err; } -- 2.25.0