Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3599362ybz; Mon, 4 May 2020 06:14:04 -0700 (PDT) X-Google-Smtp-Source: APiQypIObWUDUV+JZMrJCreARFSE7tMrL6e78RlW9VgXqkKWHz438etTQJnwnosWNP9IdHn0bVAG X-Received: by 2002:a05:6402:b4e:: with SMTP id bx14mr15143086edb.41.1588598044344; Mon, 04 May 2020 06:14:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588598044; cv=none; d=google.com; s=arc-20160816; b=zYf3F5a4zbIIaQkzy4BO3p2ImEd/bZAHjen9cS0hc2epr1aySmyGR26Y9tWFCwfUj0 A6qZWiavP/CUadLfAOCGD1EFYlpdzknh0rOyuEfG81HksUH2j/sYFfVA7QUCWmviHxg5 +QMHW5gNVHsV1TTUg5n/ugFfZXU2KH0aiEUVlLwEE412dD7KCl+bc+6nxRuGdB9YsqIg 3/FW3EqUgxCBJ9hhwkpe0JEv6uTmNQMPDeGqr4DLHdimQgGO6BfMJNJ2DICS6otZUjI9 nfiR4HXoUqvrcHYVdQk8I8jqi6WMN4pyu+7clBZEy9OHKiX638hIMRsIkUKScFDH1zS2 l5vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=3m8s1SmpUDPyyh93wOEQyoVrkzRQAwCbFZoUFGVGUQg=; b=v8+5Iu7ooW60yXlqDrp6DIkQ5H3t371/UjyPr8LNC/i2ZKrOlkIhYyMmtxF25clyQH juJBoUiGEYhkVefDynGm96XpVoYZIrRwWeZGYTvFZGz62EGdFid8uKG5zLxcqKTd0ojC fmcsFWWv5RP+c+Omb8dPc1tDLeJIuczWfMA1d1G1nhL7tQ6so/UJGKyZ1nsX/01ktmhj i7+amOgVz5Qju0RGEFoUQATKhzeLoP40jeGABCakt34iFkA9ClCOp8YJdvbzW8LvTw2Z QvbVXSUmQvwPSEnfK2Yo6V9p6MNWoQcxdTGHn5JJegESb31lyFWGAzQWnIuZjO1PEZG0 NNhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d26si7564232ejc.216.2020.05.04.06.13.41; Mon, 04 May 2020 06:14:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726913AbgEDNLO (ORCPT + 99 others); Mon, 4 May 2020 09:11:14 -0400 Received: from verein.lst.de ([213.95.11.211]:57839 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbgEDNLN (ORCPT ); Mon, 4 May 2020 09:11:13 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id F34BA68BFE; Mon, 4 May 2020 15:11:10 +0200 (CEST) Date: Mon, 4 May 2020 15:11:10 +0200 From: Christoph Hellwig To: Marek Szyprowski Cc: Christoph Hellwig , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , linux-arm-kernel@lists.infradead.org, David Airlie , Daniel Vetter Subject: Re: [PATCH v2 00/21] DRM: fix struct sg_table nents vs. orig_nents misuse Message-ID: <20200504131110.GA18918@lst.de> References: <20200504125017.5494-1-m.szyprowski@samsung.com> <20200504125212.GA17241@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 04, 2020 at 03:05:30PM +0200, Marek Szyprowski wrote: > Hi Christoph, > > On 04.05.2020 14:52, Christoph Hellwig wrote: > > On Mon, May 04, 2020 at 02:50:17PM +0200, Marek Szyprowski wrote: > >> v2: > >> - dropped most of the changes to drm/i915 > >> - added fixes for rcar-du, xen, media and ion > >> - fixed a few issues pointed by kbuild test robot > >> - added wide cc: list for each patch > > Didn't you plan to add dma_map_sgbuf and co helper? > > Yes, I have a followup patches for that, but I wanted to fix the > existing code in the first step. Then I wanted to send a wrappers and > their application. Do you think I should do everything at once, in one > patchset? That would be my preference. The helpers should be mostly trivial wrappers, so they can easily backported, and they force passing of the correct parameters. So I don't really see a need to fix up all the 20+ places up first just to convert them to the proper API a little later.