Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3618897ybz; Mon, 4 May 2020 06:35:11 -0700 (PDT) X-Google-Smtp-Source: APiQypIp8jrlsMP5MtPnMKsGE9R+QaZ0ywXdGw/glwkkBvFNqMOeId60nxilAvWLyecU8XI48Edy X-Received: by 2002:a17:906:809:: with SMTP id e9mr14415900ejd.81.1588599311686; Mon, 04 May 2020 06:35:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588599311; cv=none; d=google.com; s=arc-20160816; b=cI4RPmrqiFeuChqGMDz3XTlOOTythko3XR6fzgcD1qTrmclv+JAFWW+Zstjye/0mv8 WA2SMUsgD95vn+Z0uD5Yh391cRCPcJykojLA0mjRzwYbdVi848GYOVtEBJ11BabbFl71 y6KnXp9vwGOu6MMn96AucavtvrcWWhyp97KBPbaoyZxnNFSy8lkd0ytmRA0dcnjRyZKH DhYQsVZzgZ8M8JzRyoGGuqqAlWIXTAnLQ4Ih2AsVDJnA6umOpCE4JVPwiwd6mtCEAdLA VNdGCrWVmVN98eGMTA+x0Q+pV/Tnwx+//CIOkU1BfdS4UCvZSoQ9cSjhXFyZbKQH8zUX 8jSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=R2AgN/KkjNCB1dpfHy8VzVFJYZHqVgpnam63ptX8Tkg=; b=lAh017/4GtLKCCJLfbj+Nw0a2n0aUM2+eNR97+LkOm4o4aHCTeVLgFtJVRxNwbp8Ev t5y9VM4WBPIrkkAvulnpBAnUehp79mJZ7RcFc0FruTWqPBIYOnjPrlkc8xRRkamWEeLA x2TqmRQRoGoyy/M9xGpfIG4WMqI9aUEv57YU5Wnpd1YmZ12wgEvxl6mCBfOF0Y/nD7xg Rq6FaTjjmxZHgWpYvR0wU4+N60d1wz95ViW5JHnX4AY74gv8BX3NoJuFEpXQMMuds4es M66tm3czxSgz92EGHZggxgpBkdUzmtI2o9tSMfcXYQLQ6NAUIxokm67a87r3b51mxboT iglA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m29si6368241eda.592.2020.05.04.06.34.48; Mon, 04 May 2020 06:35:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbgEDNcK (ORCPT + 99 others); Mon, 4 May 2020 09:32:10 -0400 Received: from alexa-out-blr-02.qualcomm.com ([103.229.18.198]:8215 "EHLO alexa-out-blr-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728125AbgEDNcK (ORCPT ); Mon, 4 May 2020 09:32:10 -0400 Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by alexa-out-blr-02.qualcomm.com with ESMTP/TLS/AES256-SHA; 04 May 2020 19:01:27 +0530 Received: from mkrishn-linux.qualcomm.com ([10.204.66.35]) by ironmsg02-blr.qualcomm.com with ESMTP; 04 May 2020 19:01:07 +0530 Received: by mkrishn-linux.qualcomm.com (Postfix, from userid 438394) id EAE0346E3; Mon, 4 May 2020 19:01:05 +0530 (IST) From: Krishna Manikandan To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: Krishna Manikandan , linux-kernel@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, hoegsberg@chromium.org, kalyan_t@codeaurora.org, nganji@codeaurora.org, mka@chromium.org Subject: [v1] drm/msm/dpu: update bandwidth threshold check Date: Mon, 4 May 2020 19:01:03 +0530 Message-Id: <1588599063-15754-1-git-send-email-mkrishn@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maximum allowed bandwidth has no dependency on the type of panel used. Hence, cleanup the code to use max_bw_high as the threshold value for bandwidth checks. Update the maximum allowed bandwidth as 6.8Gbps for SC7180 target. Signed-off-by: Krishna Manikandan --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 23 +---------------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- 2 files changed, 3 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c index 11f2beb..7c230f7 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c @@ -36,22 +36,6 @@ static struct dpu_kms *_dpu_crtc_get_kms(struct drm_crtc *crtc) return to_dpu_kms(priv->kms); } -static bool _dpu_core_video_mode_intf_connected(struct drm_crtc *crtc) -{ - struct drm_crtc *tmp_crtc; - - drm_for_each_crtc(tmp_crtc, crtc->dev) { - if ((dpu_crtc_get_intf_mode(tmp_crtc) == INTF_MODE_VIDEO) && - tmp_crtc->enabled) { - DPU_DEBUG("video interface connected crtc:%d\n", - tmp_crtc->base.id); - return true; - } - } - - return false; -} - static void _dpu_core_perf_calc_crtc(struct dpu_kms *kms, struct drm_crtc *crtc, struct drm_crtc_state *state, @@ -94,7 +78,6 @@ int dpu_core_perf_crtc_check(struct drm_crtc *crtc, u32 bw, threshold; u64 bw_sum_of_intfs = 0; enum dpu_crtc_client_type curr_client_type; - bool is_video_mode; struct dpu_crtc_state *dpu_cstate; struct drm_crtc *tmp_crtc; struct dpu_kms *kms; @@ -144,11 +127,7 @@ int dpu_core_perf_crtc_check(struct drm_crtc *crtc, bw = DIV_ROUND_UP_ULL(bw_sum_of_intfs, 1000); DPU_DEBUG("calculated bandwidth=%uk\n", bw); - is_video_mode = dpu_crtc_get_intf_mode(crtc) == INTF_MODE_VIDEO; - threshold = (is_video_mode || - _dpu_core_video_mode_intf_connected(crtc)) ? - kms->catalog->perf.max_bw_low : - kms->catalog->perf.max_bw_high; + threshold = kms->catalog->perf.max_bw_high; DPU_DEBUG("final threshold bw limit = %d\n", threshold); diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index c567917..6ad7472 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -515,8 +515,8 @@ }; static const struct dpu_perf_cfg sc7180_perf_data = { - .max_bw_low = 3900000, - .max_bw_high = 5500000, + .max_bw_low = 6800000, + .max_bw_high = 6800000, .min_core_ib = 2400000, .min_llcc_ib = 800000, .min_dram_ib = 800000, -- 1.9.1