Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200504120127.4482-1-zhengdejin5@gmail.com>
In-Reply-To: <20200504120127.4482-1-zhengdejin5@gmail.com>
From:   Vladimir Oltean <olteanv@gmail.com>
Date:   Mon, 4 May 2020 17:03:41 +0300
Message-ID: <CA+h21hpaCna1r=qR8QtLWGi+ttGfNxMhcXvm2JHHgV3ZgmXxGQ@mail.gmail.com>
Subject: Re: [PATCH net v1] net: enetc: fix an issue about leak system resources
To:     Dejin Zheng <zhengdejin5@gmail.com>
Cc:     Claudiu Manoil <claudiu.manoil@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        netdev <netdev@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 4 May 2020 at 15:04, Dejin Zheng <zhengdejin5@gmail.com> wrote:
>
> the related system resources were not released when enetc_hw_alloc()
> return error in the enetc_pci_mdio_probe(), add iounmap() for error
> handling label "err_hw_alloc" to fix it.
>
> Fixes: 6517798dd3432a ("enetc: Make MDIO accessors more generic and export to include/linux/fsl")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

>  drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> index ebc635f8a4cc..15f37c5b8dc1 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> @@ -74,8 +74,8 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev,
>         pci_disable_device(pdev);
>  err_pci_enable:
>  err_mdiobus_alloc:
> -       iounmap(port_regs);
>  err_hw_alloc:
> +       iounmap(port_regs);
>  err_ioremap:
>         return err;
>  }
> --
> 2.25.0
>

Thanks!
-Vladimir