Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3653132ybz; Mon, 4 May 2020 07:13:44 -0700 (PDT) X-Google-Smtp-Source: APiQypIeMB8NgJlY9qtthez0Tq1kJLYlGWxQgXrPceOhcerBr0+LRUoXasZhr+syVGeUMUBGHdeT X-Received: by 2002:aa7:df0a:: with SMTP id c10mr14637560edy.306.1588601624082; Mon, 04 May 2020 07:13:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588601624; cv=none; d=google.com; s=arc-20160816; b=R4M96weZcW0kuqo41AJubaLd5/fofWsLSgDBfYh5I2Qj4vZE/tyU7AlOum81PmQXJr kbWP92O1TOU5s9BxAfUVwSkz48zMyAaqHtWqJBOjn/JBlxpMfpHOpxjLG8jwnltkl34E 0PfXXZOKybx1RzQFG2AwCL0joNKfQ1xmsdScLb1h6nU8x6U2zu3wheyylM7abYZrFFwV DEsaQPe69eL0QVIYAmA/HudBvNk5TSAPPnaJbG9YRRLRb2G+pgFiUPo713fvH2tVOKgL tIntxiw8s9SYSq6qaX1i36ZqIfqLZ01G3AwaRdwKn3Sdi8xW0KW6W61egRbtxn0Y5EJO mUXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:ironport-sdr :ironport-sdr; bh=NENoSR5kHzLzIgTL6VeJoNAjPk7jQ758c5t0YM9x21E=; b=hAXBc66TV6wDByh8gUwtCIFjnm5H2Rix5A2MrJIVjXRzhd+AI57YQksn9dhgimPZtx 5X2y/ahsT98/O/i0F0vviCVOlyfkGvm7pPEHMErW5hwuU1vZrzAXeIXj0Flf6l05LbnY 4F3hSXC4TQ5D/hkxQ1mz+aK6AZ20P1pAQGNsIt3IGoBjwmBs1QrS67wtjbEqpfyO4Ftl jwkjKtdhe0HxhpvmK8Dx0AGJRrXiJijTisvyZ7vnT91aG4DZrWWPcOpEmdLCZtiDFu8S x1emUzIXdB8yhQ6u4CSFofk26k3k3Wc3KZtFrlwjl/3zhsDQyGs6cqy84QfIqnSEKWWJ 5gIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si6708387ejd.260.2020.05.04.07.13.20; Mon, 04 May 2020 07:13:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728883AbgEDOKy (ORCPT + 99 others); Mon, 4 May 2020 10:10:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:52024 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbgEDOKx (ORCPT ); Mon, 4 May 2020 10:10:53 -0400 IronPort-SDR: FnjQlJtew1ULL8NanbcLVmCWaMBgkT4jMOQ5z+dtgb0LPSLDW/yZin95YWL9xgHA9g06MEJBz5 uP3YYX++dK1Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2020 07:10:53 -0700 IronPort-SDR: M1u1YSU8rla24ATntvB5kKSFZaHH+mPOXbGrfF2vYxiupehh1k8L9qq0dl3lyCYri4N+dbpFkd gz06U246+3Pw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,352,1583222400"; d="scan'208";a="262831961" Received: from fmerchan-mobl.amr.corp.intel.com (HELO [10.255.229.65]) ([10.255.229.65]) by orsmga006.jf.intel.com with ESMTP; 04 May 2020 07:10:53 -0700 Subject: Re: [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c To: Mauro Carvalho Chehab , Linux Doc Mailing List , Shuah Khan Cc: linux-kernel@vger.kernel.org, Jonathan Corbet , Andrew Morton , Stephen Rothwell , Sandipan Das , Ram Pai , Thiago Jung Bauermann , linux-kselftest@vger.kernel.org References: From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Mon, 4 May 2020 07:10:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/4/20 2:44 AM, Mauro Carvalho Chehab wrote: > Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book") > from Jun 7, 2019 converted protection-keys.txt file to ReST. > > A recent change at protection_keys.c partially reverted such > changeset, causing it to point to a non-existing file: > > - * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst) > + * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt) > > It sounds to me that the changeset that introduced such change > 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name") > could also have other side effects, as it sounds that it was not > generated against uptream code, but, instead, against a version > older than Jun 7, 2019. > > Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name") > Signed-off-by: Mauro Carvalho Chehab Thanks for finding this! The patch set which moved protection-keys.txt out of x86 code probably just missed this when it got rebased. It originated well before June 2019, iirc. Acked-by: Dave Hansen