Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3685076ybz; Mon, 4 May 2020 07:50:28 -0700 (PDT) X-Google-Smtp-Source: APiQypINPEgnE3e3k0qCsJaGv67JvwQkq+o7l/f0p78OYub5YSPmrMIi0jlsktDLNXDSIw28mI+c X-Received: by 2002:a17:907:42d6:: with SMTP id ng6mr14825374ejb.265.1588603828773; Mon, 04 May 2020 07:50:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588603828; cv=none; d=google.com; s=arc-20160816; b=bkx2f4MtNqoXNogwYDR9Fmw86UFbgSc4vIGaxnVGNuuB70/63W74iIUacBoJDJBSfx Wc+W5GRQxVSog93RU50NRYN+YZja5SCZUKIAOY5N9rOyE0b1d8JmPLobh34W/usw3q5h RLPp4cb/FJjLAQiJCc8H19pMj5LaNu8adbSDC/F4Nxp/IfkzOA0q1cEwvfXc8iHKeAmr E5ZXuJ6TTRc1QqnT5FoJFUkv6IgTawYr/P46wiNPpdGCzzA7sMtFtf7CWLjvWiYmQa0n TJ5OXecRBlX50NMJCpDE9LqFYCqx0XDSPKa0/2iCpylJJX26r/FQ4/FcmlVr88CxSblq lQDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=aZCAvQbmlt2PgelZcbg6FQn8FAGGZDkD52dqItuXb4U=; b=NSC8bXBN7x7VOXQWbDLvvpaAweBvI5XyCCVOWBetHWR3ZZnqqFbchqH0vPwl7579Gi jJn/4soRA8wrkUwF5ucS4EnwC4LL4Uu6+rolZbPxdS8oiSusAgcyyHwCwY1pg+foLhJV eyMu1NwnwGuOzRfCPi5mRV71r0uhy4onVyluIK/3ldUcxK8yuxqFyVHegae6GLxQ9a6O i3f8dcULuJdYTHbFFHtdrVXnJpREQzIwznT4tlePYU4nZpYlH8/MJlhYHcv0CJiAlkn/ VzE2tzmzSI+m7aUw0NWA5pbh5qbCGzxVUfC7moUy2r3eHZ1/h5UFX2jYfCc1qovcCqq5 Nbhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si6196254ejx.520.2020.05.04.07.50.05; Mon, 04 May 2020 07:50:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727871AbgEDKKQ (ORCPT + 99 others); Mon, 4 May 2020 06:10:16 -0400 Received: from mga06.intel.com ([134.134.136.31]:50967 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbgEDKKQ (ORCPT ); Mon, 4 May 2020 06:10:16 -0400 IronPort-SDR: ABPYJ/XjenKMfjxbrEQIxK3JF3CPB8hjh0B7xWDfIdk4pOmQnwHYKmpBEuLR9Ds0v1rOfFC9vU /q4jZhKxxAKA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2020 03:10:15 -0700 IronPort-SDR: BDVxcggN+h9n0YU3gnuw2ItbbJHk7bjEHBGfqBJvAw/SBwFBaY5WX2FegrwUyzv76TCVxz263+ aBjxWBpodEFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,351,1583222400"; d="scan'208";a="259285901" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.170]) ([10.237.72.170]) by orsmga003.jf.intel.com with ESMTP; 04 May 2020 03:10:14 -0700 Subject: Re: [PATCH] xhci: Prevent runtime suspend all the time with XHCI_RESET_ON_RESUME quirk To: Kai-Heng Feng , Oliver Neukum Cc: Greg Kroah-Hartman , "open list:USB XHCI DRIVER" , open list References: <20200504091952.15820-1-kai.heng.feng@canonical.com> <1588585655.13662.5.camel@suse.com> <88A0FF32-C7D7-4E49-8470-FE23401371BD@canonical.com> From: Mathias Nyman Message-ID: <6fca4532-b4a2-9730-bd96-5ac15357f752@intel.com> Date: Mon, 4 May 2020 13:13:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <88A0FF32-C7D7-4E49-8470-FE23401371BD@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4.5.2020 13.02, Kai-Heng Feng wrote: > > >> On May 4, 2020, at 17:47, Oliver Neukum wrote: >> >> Am Montag, den 04.05.2020, 17:19 +0800 schrieb Kai-Heng Feng: >>> Etron EJ168 USB 3.0 Host Controller stops working after S3, if it was >>> runtime suspended previously: >>> [ 370.080359] pci 0000:02:00.0: can't change power state from D3cold to D0 (config space inaccessible) >> >> Apparently this controller has issues with D3cold >> >>> [ 370.080477] xhci_hcd 0000:04:00.0: can't change power state from D3cold to D0 (config space inaccessible) >>> [ 370.080532] pcieport 0000:00:1c.0: DPC: containment event, status:0x1f05 source:0x0200 >>> [ 370.080533] pcieport 0000:00:1c.0: DPC: ERR_FATAL detected >>> [ 370.080536] xhci_hcd 0000:04:00.0: can't change power state from D3hot to D0 (config space inaccessible) >>> [ 370.080552] xhci_hcd 0000:04:00.0: AER: can't recover (no error_detected callback) >>> [ 370.080566] usb usb3: root hub lost power or was reset >>> [ 370.080566] usb usb4: root hub lost power or was reset >>> [ 370.080572] xhci_hcd 0000:04:00.0: Host halt failed, -19 >>> [ 370.080574] xhci_hcd 0000:04:00.0: Host not accessible, reset failed. >>> [ 370.080575] xhci_hcd 0000:04:00.0: PCI post-resume error -19! >>> [ 370.080586] xhci_hcd 0000:04:00.0: HC died; cleaning up >>> >>> This can be fixed by not runtime suspend the controller at all. >>> >>> So instead of conditionally runtime suspend the controller, always >>> prevent runtime suspend with XHCI_RESET_ON_RESUME quirk. >> >> What does that do to other controllers that can do runtime suspend >> under the current scheme? > > Ok, I'll add a new quirk specific to this controller. > > Kai-Heng Host shouldn't runtime suspend by default unless set by userspace, or it has XHCI_DEFAULT_PM_RUNTIME_ALLOW quirk set. -Mathias