Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3685265ybz; Mon, 4 May 2020 07:50:45 -0700 (PDT) X-Google-Smtp-Source: APiQypJ3KjFWJUQne5519xBKhCQp1U//o79EKlCFG1Nfrix72rb+whNes7FWHWcly2e0j6BDwf/X X-Received: by 2002:a50:e841:: with SMTP id k1mr15483037edn.245.1588603845739; Mon, 04 May 2020 07:50:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1588603845; cv=pass; d=google.com; s=arc-20160816; b=qxKT8s+cfNc+6LiTG+vDXsyD6uZDTsquTKBuTcWDUJJEMO99d1bR2Ff0rJfr2FQ4ib m7XWPy3Ttyh2kZhjEX4q4YYg3j08mfa1YO4mqlreg+np6k4f/w/M48BHDo5Olap5Gknu qPo6yzHdO87I7+i58VLNMYC7AYD4Sv311Q+rdJBrzPcP3O+Z5iWW5COHMb4FWmajpJUc Nwbet2cjGmhqUPrDkB0yQ9vhu30yAECcfFfiCK9TrD+AgJbw6Lq56RkByP/YBqqdSRmA qbg/GuRKNbAlS7eZUPH1/hx5czAMRP+SsAjSvTSgQWNzAeqwAFjofqWyR1g+osBhZiPz IRzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :wdcipoutbound:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:ironport-sdr:dkim-signature; bh=CBrXMGNmfuPgRYboGXskCcGcamN9Oase54vLZm12Wrc=; b=B495hWOiC8QQSJ6NUb1RQZrDyoofOQDfdxGY6KlP5nQ8JKg7JL70UzTe6Utcwhzg8Z f414GdSSfZydaWVRKOhVkOJqyUtqFt+8xlxqGM8L4UWb1BK5KUuI4YUPlTHbnE9tQSvw twBfIK/et3g5cuRCAQKHBfW5a5pXkRVEZhTEbaAL2KY++4QieHpJ2iuGaW+o9s+rMwxJ gxqC2DMDMR2UAT/gjfyZAaa3u2A06bY7jfFAN3XGmabU78aR5OPN3CSK9Tj798sWadKX E9C4GNI63+1699peN5pFFwRs4ublGfvxtxZrA/FvfSC+9VLTpLJP4KAhbqcxoX1HEGCm J62w== ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=mcEMa+bm; dkim=pass header.i=@sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=HMkcqGNC; arc=pass (i=1 spf=pass spfdomain=wdc.com dkim=pass dkdomain=wdc.com dmarc=pass fromdomain=wdc.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g18si6666739edm.285.2020.05.04.07.50.22; Mon, 04 May 2020 07:50:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=mcEMa+bm; dkim=pass header.i=@sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=HMkcqGNC; arc=pass (i=1 spf=pass spfdomain=wdc.com dkim=pass dkdomain=wdc.com dmarc=pass fromdomain=wdc.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728169AbgEDLDm (ORCPT + 99 others); Mon, 4 May 2020 07:03:42 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:18841 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbgEDLDl (ORCPT ); Mon, 4 May 2020 07:03:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1588590220; x=1620126220; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=T2Ad+xhss7QEUq6ACAoeVJMtAF5NTKjVDRG0qnqJk4M=; b=mcEMa+bmB5gKCMhU+VbkZ7sLbYNRYILO/M9YzHkQDbUzmrPf/tfkld7e VF9d1KXaGDjjdlcfryiK9pUIbabvZ2TijunqR4yLBBMdE3UdJYKxeLSUJ CphHb08dwSqhxMbZg0yTkpCkuq7rGRYRU/WfDvJlwU65veRPuZhqyGkLB vsZMoSv7Ds2D4CRjdXicg0qFabRC0W3NMd7wPlHPawkgnAv/FtVDtd1D8 +OZQRknY+EyKkVG0C1f2fL6sUFXLsgiXM2Rez610nqTDZQbcVBGLpKEDq h08KJzTHgMYx+nY8pRMqE6j6OnzmIyaRWinzybC2EpaYQHognXL5lPh77 A==; IronPort-SDR: TkHLjhkNCssM/54UEuoLifdtWCRDV+TQjGqNzQuCtfU63PFsOqq9NIn9it4tXpty+S/Qx4uk0A uXxMDqbft7/ZdP0LF+XZf+++pNVtFEX8OYkOKgVT5xFO3+g9bBIaJp6qaDmLgjUVN3OOhGHedQ eQ8ILIzU6tfOoNM29spfHkLijtcfkFzttiEYku8Y3FzCEguDHgspOwN2H9Qa0VhJjA6IG/S1xd E2qi4olvwVVV+W7qAXeVWzctu+oGH9q1/Cwp7LBoW4oZsaOFrFc6dRRs/lkIS7fg2IbWSzdTm+ Lq8= X-IronPort-AV: E=Sophos;i="5.73,351,1583164800"; d="scan'208";a="138293344" Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101]) by ob1.hgst.iphmx.com with ESMTP; 04 May 2020 19:03:38 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZD4qD4vdl1RmyZ8LPqKI9dFYBNhxGOBxyyKolIeUgImvRMLNtnDg2hUDh92ODTBfZieeZhE67FIUIfT/X8b5wwhxb+2iuL8O9kg4pF0O96mOnQd2u64vkEjOtm19n/z9KcVW8NfuCLjrfKilv8+mLJBPArs0yx2O4M6gjU0NR5AsxenFt+WF5s5YsRlhjdesrOGR1e54Ar6Y/AXkhsoEafn89jG3a+vSKBu2lcnOe+Hlp0FPhHizHe7a2soZx0X6+i1zgv6DHqNw/A0QZB28kAfURsHEFkRc8cDljCf2Lo42G6GcHOPEK6ga29ebRrr/wMC9vh8Jsttb5f+Y5qkykQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBrXMGNmfuPgRYboGXskCcGcamN9Oase54vLZm12Wrc=; b=PR8NhrPMpHDPdBdC0Z0gxGfMfSxIENuw3klVltjdkH5EdVVZHWhdIRJwhcpvPwu8pQ+nvuwRym1WGZVzAWsyMmm1Sp5DrE/mVsOAxYjbTjUqObSqoqw58InNjjo6KysLwX10YpEdBd+WVdoAU+Hvt6TXyLSrv9C4rpnAWTJCnZY//gkgtXOCegjKtBNxRDADYpjcMU/H8fdHZZSuE11UnY9WLoK3Ne+Ay5OmWRnsUADJPGRrsA3leV/X46DgQjSClBwkrk88jVBOPn/6gaawld1UAFDkxco0khodpLLSbja/8r/HQpkuhasogkoaXafSw70R/GnDwGuJPaFf0gnfRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBrXMGNmfuPgRYboGXskCcGcamN9Oase54vLZm12Wrc=; b=HMkcqGNCFCg55p8goMbRiT814V/YmjZWycXgjRM+9RQmCzNhEcEl12N5BmNg4my4ffVsgsWJGxQlREfAJY6na6emYlU6d5qsuXtAAG0rV4WjhVXfzUBRX79NHAKnkIFShbab9y3KKkgXtriSW2PBYVEkJbmBKrXjPJcJ6rV1veI= Received: from SN6PR04MB4640.namprd04.prod.outlook.com (2603:10b6:805:a4::19) by SN6PR04MB4464.namprd04.prod.outlook.com (2603:10b6:805:b2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Mon, 4 May 2020 11:03:36 +0000 Received: from SN6PR04MB4640.namprd04.prod.outlook.com ([fe80::9cbe:995f:c25f:d288]) by SN6PR04MB4640.namprd04.prod.outlook.com ([fe80::9cbe:995f:c25f:d288%6]) with mapi id 15.20.2958.030; Mon, 4 May 2020 11:03:36 +0000 From: Avri Altman To: Stanley Chu , "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "alim.akhtar@samsung.com" , "jejb@linux.ibm.com" , "asutoshd@codeaurora.org" CC: "beanhuo@micron.com" , "cang@codeaurora.org" , "matthias.bgg@gmail.com" , "bvanassche@acm.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kuohong.wang@mediatek.com" , "peter.wang@mediatek.com" , "chun-hung.wu@mediatek.com" , "andy.teng@mediatek.com" Subject: RE: [PATCH v5 4/8] scsi: ufs-mediatek: add fixup_dev_quirks vops Thread-Topic: [PATCH v5 4/8] scsi: ufs-mediatek: add fixup_dev_quirks vops Thread-Index: AQHWIT7UcNDlRrxlf0S0WlJUL1qmaqiXwh9QgAACjFA= Date: Mon, 4 May 2020 11:03:36 +0000 Message-ID: References: <20200503113415.21034-1-stanley.chu@mediatek.com> <20200503113415.21034-5-stanley.chu@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mediatek.com; dkim=none (message not signed) header.d=none;mediatek.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [212.25.79.133] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1202ed4f-8872-4489-038f-08d7f01acb49 x-ms-traffictypediagnostic: SN6PR04MB4464: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 03932714EB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6CZ1txf016gqnCo7nLtnYC0mjL1CSwi9QRjCeFyBlIw0sw8SpzGzDLS7vPmwuY6RMvPgVniDU8IbP0HhOg2jrWkFyL1cuqkn/g8mci2hi2VsaYfNzLPb2oe9D4nRb26LPjK6CsuDlZFbF+RE705pkugLWT+Xikm5zXDppiuYebyW2wpNR7WqX2AavdzqDXQ6J10lw9spQJUQ7A5Yr+MVLtWyDXvQGsGCj0cDL6CbYneIR5OLXZCB/4yttvjRdSj8FkSPa6tMtO4XxUpGERLvykIIdy4CRx92cy9WyDQgxryQhhUOvINcTgcbmjA2Umg+PqlV472B0P/yRdoyPx7B5MZKOhUjn91R0uQAGEDA5k4Xm7/tSdDO46M1Ub0MtsYy/dVT2diahkUe8LoOQmlly3/AoKSpVaMDos4c99WF48DmJp+0HusXF7CSvFJUFnRz x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR04MB4640.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(376002)(39860400002)(346002)(396003)(136003)(66476007)(8676002)(26005)(2906002)(52536014)(6506007)(71200400001)(478600001)(33656002)(5660300002)(86362001)(2940100002)(64756008)(4744005)(55016002)(9686003)(7696005)(66946007)(54906003)(66446008)(76116006)(4326008)(66556008)(186003)(8936002)(316002)(7416002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Lpot51sJtCNQQeharX17bbSwi7M1/KrhQFnZqPJbcuZ0sHRfKwaOQFuoPnNpPJPthNbck7XsdqW327RYNd7OI+OavLCw1hD3B/ogrsVvIKbBm3Hj9bMDiibVJ3we1OatQhHVUmapoMVbwE8UXYvws9bPkWF/FClcXZ8uUInvvJ1aLSY+jzj8C+t6QKWwUY8dEYIwVnZItX3APA9dpHNVGCm8bomyVNFnewmEGlSvrNiVt6MSpfAVCsYD4NdfL084XtdSe87Db7n4LU0ShqV13GPK/DE7j2rCq+XJkI/LSBy+ZtxHc6EUT8JXzH02wBcvikOT/p+glEgmvA6ZbrPazkkP2dEaRYU7Ho1e92mnWIs8M9r93O15ViH3J8CGwOxqjSSQSXKcWv5VRyp66RSdmGxtEGZTjaNYyxEqHt0+GFkUS2wghAl21vYZTLcgUIBuGvdrEFj95S3LH3yfYlsIZ/YivAm5dmgX1keBKplvdApw5RMtSa5N7J9Zq/MOoAMyalj8OrtKXjZUgXYRQXwlRtiiFDO2Idn5wIZMdjMnPoodMDxtrSRR2TVEM73b7qfIlkNLE7yrbbAg8J1aEtRGhUW6IFlOC/paV0ltaLApytlFHr35bT2RMITVXP1+RWMMzVlwntH5mih2TVwJVPVdaEj5iIZa+ILhdo5qnGA2c0Je+wMmMHItEdgFqr0OTIPDxP7Nus3ODdVy5YdsHtNMGLS3qyN1hOAULQeiUi96POdbZw95AhQp64VSaRFwSxjOAyZuyPZEiYTGnOB6XQV0jIiORFNpr1BsejmYTIiPXw0= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1202ed4f-8872-4489-038f-08d7f01acb49 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2020 11:03:36.5480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dX+4qjBcvvlo96IV4U5oSMj3xg7TCmznIToe4oB+L5ORPqeT9vs74XynAIsFsxzXbaNxOSLy+RbpFBoN+/r/aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4464 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > +void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba) > > +{ > > + struct ufs_dev_info *dev_info =3D &hba->dev_info; > > + u16 mid =3D dev_info->wmanufacturerid; > > + > > + ufshcd_fixup_device_setup(hba, ufs_mtk_dev_fixups); > > + > > + if (mid =3D=3D UFS_VENDOR_SAMSUNG) > > + hba->dev_quirks &=3D ~UFS_DEVICE_QUIRK_HOST_PA_TACTIVAT= E; > Why move it? It is a unipro/hci param. Actually - please ignore. Thanks, Avri