Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 May 2020 11:38:43 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To:     Joerg Roedel <jroedel@suse.de>
Cc:     rostedt <rostedt@goodmis.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Borislav Petkov <bp@alien8.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shile Zhang <shile.zhang@linux.alibaba.com>,
        Andy Lutomirski <luto@amacapital.net>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Message-ID: <1533922227.82188.1588606723786.JavaMail.zimbra@efficios.com>
In-Reply-To: <20200504153135.GJ8135@suse.de>
References: <20200429054857.66e8e333@oasis.local.home> <20200430191434.GC8135@suse.de> <20200430211308.74a994dc@oasis.local.home> <1902703609.78863.1588300015661.JavaMail.zimbra@efficios.com> <20200430223919.50861011@gandalf.local.home> <20200504151236.GI8135@suse.de> <99290786.82178.1588606126392.JavaMail.zimbra@efficios.com> <20200504153135.GJ8135@suse.de>
Subject: Re: [PATCH] percpu: Sync vmalloc mappings in pcpu_alloc() and
 free_percpu()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: percpu: Sync vmalloc mappings in pcpu_alloc() and free_percpu()
Thread-Index: koijJ/z6mXCPro7wCDn7K0mtIqgv5g==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

----- On May 4, 2020, at 11:31 AM, Joerg Roedel jroedel@suse.de wrote:

> On Mon, May 04, 2020 at 11:28:46AM -0400, Mathieu Desnoyers wrote:
>> ----- On May 4, 2020, at 11:12 AM, Joerg Roedel jroedel@suse.de wrote:
>> Placing this here is inefficient. It syncs mappings for each percpu allocation.
>> I would recommend moving it right after __vmalloc() is called to allocate the
>> underlying memory chunk instead:
>> 
>> static void *pcpu_mem_zalloc(size_t size, gfp_t gfp)
>> {
> 
> Tried this before, actually I put it into the caller of
> pcpu_mem_zalloc(), but that didn't fix the problem for me. Stevens
> test-case still hangs the machine.

That's unexpected.

Did you confirm that those hangs were also caused by percpu allocations ?

Maybe adding the vmalloc_sync_mappings() at each percpu allocation happens
to luckily sync mappings after some other vmalloc.

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com