Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200428212357.2708786-1-arnd@arndb.de> <20200430052157.GD432386@unreal>
 <CAK8P3a25MeyBgwZ9ZF2JbfpVChQuZ1wWc6VT1MFZ8-7haubVDw@mail.gmail.com> <20200503053005.GC111287@unreal>
In-Reply-To: <20200503053005.GC111287@unreal>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 4 May 2020 17:41:56 +0200
Message-ID: <CAK8P3a30Qe=_L0Ji9k14SwGEZAKUX5FJ5YsFACGz_X3oBSSNQQ@mail.gmail.com>
Subject: Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Saeed Mahameed <saeedm@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>,
        Moshe Shemesh <moshe@mellanox.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Networking <netdev@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, May 3, 2020 at 7:30 AM Leon Romanovsky <leon@kernel.org> wrote:
> On Thu, Apr 30, 2020 at 04:37:14PM +0200, Arnd Bergmann wrote:
> > On Thu, Apr 30, 2020 at 7:22 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > While warning limit is generally 1024 bytes for 32-bit architectures,
> > and 2048 bytes fro 64-bit architectures,  we should probably
> > reduce the latter to something like 1280 bytes and fix up the
> > warnings that introduces.
>
> It a chicken and an egg problem, I tried to use default frame size, but
> the output of my kernel build was constantly flooded with those warnings
> and made hard to spot real issues in the code I developed.
>

When did you last try? I usually send patches whenever I see a new
warning, so there really shouldn't be any such warnings in the mainline
kernel except for cases where patches are still under discussion.

If you have a configuration in which you see lots of frame size warnings,
can you send me that .config file for that? It is possible that one or
more of the patches in my backlog fix a bunch of those issues
and need to be resent.

      Arnd