Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3752570ybz; Mon, 4 May 2020 09:05:38 -0700 (PDT) X-Google-Smtp-Source: APiQypISK/m/OsSLqCFlvZu8OULTPHAp0Fi9vzi6/Wlkwfsjh6BLMmQeTD24g86++wenyO08t71S X-Received: by 2002:a17:906:9a1:: with SMTP id q1mr15288001eje.296.1588608338318; Mon, 04 May 2020 09:05:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588608338; cv=none; d=google.com; s=arc-20160816; b=ws0HLJ8hEoG2B1V+/RNmRRAaDKF57sY+cb3pJdnHU3PfzYUDcsfU4Sv9k5nOZMo0W9 fUzF5XlR92vRu5l5AuVnVkbIdr6Q2UEDQW+PmEp5Cz/qVt5zisaCxprsMdW4QUhvtRXB CGAnvwLJ49Jb01qwT4upsm70+7S3cT+8WQil9DNuoFWhQgrBqmzHfARWApI+Rg6DngEf 63DWibVboJNWwfATy0lWsVYm6UM6A1oQTkblf2ky76GnwTAKULVNZjjo2XQFMFEAWHrF a42a8hDQB+zUTl2VXIXKwD6OZ+T5EgRMgAHKgZ8p7z3X9lIwp4EwoDHcNbh/X+il+jF+ lVkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=MJiG06idgkhQ7ETomKvk+pXIhWmcVzgg6Sh67pMiRa8=; b=ueYtpI/ZHyBOrCeXtyVtvZwq9oU8bc8GrIAoJ5qoeywEhgnQ1HH+DkjhG1UpTXa6Mg 36w7PYmG66TaTwSb2NARUR1n0r0GEOtXotqKffI66ReMsWSyjuDlt9dcM0XU7smxLtRG wfAvpR6GBsoJuHZ3sQpwROewOYXR3Bxlbv1nGY20xkdbejuKaV8N0oMI3ROeWPNc3Mig 8pwtj0qSRsZsRT3hEQsSngwQAGjhKPAYXjafbUGRqKQIZaJjVx8GLho3664Nzhm2rL/c RogH/W9PWZprQzz7Eq4kZkt3dXqGhruFEJImjzWh1vN9JDBN6Jir8P0ggClBAkzIMJ15 ibqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=KSO+cu4K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bd4si6548491edb.607.2020.05.04.09.05.05; Mon, 04 May 2020 09:05:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=KSO+cu4K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729141AbgEDQDR (ORCPT + 99 others); Mon, 4 May 2020 12:03:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbgEDQDR (ORCPT ); Mon, 4 May 2020 12:03:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71AA5C061A0E; Mon, 4 May 2020 09:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MJiG06idgkhQ7ETomKvk+pXIhWmcVzgg6Sh67pMiRa8=; b=KSO+cu4KS04f9QMSMnoEgpz4lP xEUzzhMHMNy0nNQLb/oWLnGEmta0IgfeMaWPLFVU8v0KE5Q/SQ/kf7eZZQbtkWd1mh1jOtqlamJpr YN+qE50vHOxXepS7SXteLP+Jz8YM7GoPnzdBjtA78HfjZE5ci7Ix61JXsgZmNOz3ITCwjRyIZY+8f VyOZXfNmnntPRCfh/xfRBQBe6qX2/BPIpwkpCgcPE5LJxYzBjMyx5sO7eU8s1XolUvo0+SbSxsYHA IxtQuHWPpYcGkzHJS2c5PU+nqLHZ77pbjoE7P9V0lYxoaoYguZ5auscSJkpBNu3v2LiCVcQSeLZB2 eIpOBNEQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVdYo-0007fF-8J; Mon, 04 May 2020 16:03:14 +0000 Date: Mon, 4 May 2020 09:03:14 -0700 From: Christoph Hellwig To: Chris Wilson Cc: "Jason A. Donenfeld" , Christoph Hellwig , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, bigeasy@linutronix.de, tglx@linutronix.de, stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: check to see if SIMD registers are available before using SIMD Message-ID: <20200504160314.GA26373@infradead.org> References: <20200430221016.3866-1-Jason@zx2c4.com> <20200501180731.GA2485@infradead.org> <158853721918.8377.18286963845226122104@build.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158853721918.8377.18286963845226122104@build.alporthouse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 03, 2020 at 09:20:19PM +0100, Chris Wilson wrote: > > Err, why does i915 implements its own uncached memcpy instead of relying > > on core functionality to start with? > > What is this core functionality that provides movntqda? A sensible name might be memcpy_uncached or mempcy_nontemporal. But the important point is that this should be arch code with a common fallback rather than hacking it up in drivers.