Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3755268ybz; Mon, 4 May 2020 09:08:12 -0700 (PDT) X-Google-Smtp-Source: APiQypIi5btvnAG4eauh8WCuVpBcbr3ZfcdGn02WiDyRK+qHcS+klKyKYz0mrkqnIbKx+XdTESGn X-Received: by 2002:a05:6402:1b91:: with SMTP id cc17mr14846126edb.46.1588608492413; Mon, 04 May 2020 09:08:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588608492; cv=none; d=google.com; s=arc-20160816; b=ac9PID6JXmHHZe9eO0+ascHDs1i5taCk3+2BdxzzwIDjALBePCWCoCZAUHXQCxgTTX zvFJow4hb22DJDJn1kPXCvOpNbguf8/LoyaZNZXWdeVvB+gWg+5sJ3lH08UCzBQteiCz NXC88SUY6AnQjdj7CJPqyd97SD77kRbqZIvBP5lMRBT92xMAXCBd8GQmR5X830jeS0Uf LAJhlsc893QlNYuijAw6gRAbqCAFfOBFKPDse3RVAXKRKN71DCpbvvcPJwWq5bJSBoK/ Ih5qIif1trGeZd1/nZHMjQv9gOg3CO6QHGj/9t/6xnptpOO1VPK7c/MZNcl4xBJLJ0n8 5O5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=SCdTq/KIGcpTH3fa8BX8pjdqja/Aed57yhSOr2Ffx4I=; b=emqywMotTMHaIEiXBx+OEkdOBztyR/wE8Cq4J1tu5L4dytZMOQenRBJd6Pm+Uy+q87 RjSFqTzH0eVk3Z4K4FlWCAak5TPMrgWvU8pkHv/barbP5yoNPNwHasJqfngOJbSF59A6 PW5EP5YoNFI4nJJfHnFElZZFfGfd2Tcrv0YklXo6M1fKOisbNnCFl1yoZlYqbfEiZyaw RxGZjbje/qGKvocu0EhsMK3/0/P/xqSVfY5JoorHXDdVRuRAf7L5Vmhxsms2WyxKxM4w y3pP5e5BZpYzsCcjFtXGsqzdVJVkaPFqfisF/4Gh/Eb0ufBd3SNJbfRRZ6zgepB3XuUR ci9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si6960213ejk.214.2020.05.04.09.07.49; Mon, 04 May 2020 09:08:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729450AbgEDQFK (ORCPT + 99 others); Mon, 4 May 2020 12:05:10 -0400 Received: from www62.your-server.de ([213.133.104.62]:45066 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbgEDQFJ (ORCPT ); Mon, 4 May 2020 12:05:09 -0400 Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jVdaZ-0004zi-1W; Mon, 04 May 2020 18:05:03 +0200 Received: from [178.195.186.98] (helo=pc-9.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVdaY-000HF6-Hv; Mon, 04 May 2020 18:05:02 +0200 Subject: Re: [PATCH bpf 0/2] bpf, arm: Small JIT optimizations To: Luke Nelson , bpf@vger.kernel.org Cc: Luke Nelson , Shubham Bansal , Russell King , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200501020210.32294-1-luke.r.nels@gmail.com> From: Daniel Borkmann Message-ID: Date: Mon, 4 May 2020 18:05:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200501020210.32294-1-luke.r.nels@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25802/Mon May 4 14:12:31 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/1/20 4:02 AM, Luke Nelson wrote: > As Daniel suggested to us, we ran our formal verification tool, Serval, > over the arm JIT. The bugs we found have been patched and applied to the > bpf tree [1, 2]. This patch series introduces two small optimizations > that simplify the JIT and use fewer instructions. > > [1] https://lore.kernel.org/bpf/20200408181229.10909-1-luke.r.nels@gmail.com/ > [2] https://lore.kernel.org/bpf/20200409221752.28448-1-luke.r.nels@gmail.com/ > > Luke Nelson (2): > bpf, arm: Optimize emit_a32_arsh_r64 using conditional instruction > bpf, arm: Optimize ALU ARSH K using asr immediate instruction > > arch/arm/net/bpf_jit_32.c | 14 +++++++++----- > arch/arm/net/bpf_jit_32.h | 2 ++ > 2 files changed, 11 insertions(+), 5 deletions(-) > Applied, thanks!