Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 May 2020 18:56:14 +0200
From:   Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     "Maciej W. Rozycki" <macro@linux-mips.org>,
        linux-mips@vger.kernel.org, clang-built-linux@googlegroups.com,
        Fangrui Song <maskray@google.com>,
        Kees Cook <keescook@chromium.org>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Paul Burton <paulburton@kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Jouni Hogander <jouni.hogander@unikie.com>,
        Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>,
        Borislav Petkov <bp@suse.de>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit
 kernel
Message-ID: <20200504165614.GA15545@alpha.franken.de>
References: <20200413062651.3992652-1-jiaxun.yang@flygoat.com>
 <20200422143258.1250960-1-jiaxun.yang@flygoat.com>
 <alpine.LFD.2.21.2004230036480.851719@eddie.linux-mips.org>
 <B307BFAC-9973-4444-B69A-40B054210E84@flygoat.com>
 <alpine.LFD.2.21.2004241316360.851719@eddie.linux-mips.org>
 <20200504154613.GA14031@alpha.franken.de>
 <86D4A0AC-59E1-4C82-B66D-6BFC71E08376@flygoat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <86D4A0AC-59E1-4C82-B66D-6BFC71E08376@flygoat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 05, 2020 at 12:09:46AM +0800, Jiaxun Yang wrote:
> 
> 于 2020年5月4日 GMT+08:00 下午11:46:13, Thomas Bogendoerfer <tsbogend@alpha.franken.de> 写到:
> >On Fri, Apr 24, 2020 at 01:22:30PM +0100, Maciej W. Rozycki wrote:
> >> On Thu, 23 Apr 2020, Jiaxun Yang wrote:
> >> 
> >> > > Alternatively, have you made any attempt to verify if actually replacing 
> >> > >the setting for VMLINUX_LOAD_ADDRESS would be safe?  Glancing over its use 
> >> > >there do not appear to be many places.
> >> > 
> >> > Limited experiments showed it should be fine...
> >> > 
> >> > But MIPS kernel has some design I'm not really familiar with like SYM32 for
> >> > 64-bit kernel and special address space design for Trap-and-emul KVM.
> >> 
> >>  This only affects CONFIG_32BIT kernels, so SYM32 does not apply; I can't 
> >> comment on KVM.  There's still that bunch of:
> >> 
> >> $(shell expr $(...) \< 0xffffffff80000000)
> >> 
> >> constructs I mentioned before, so let's leave your change as it stands at 
> >> this time.  Please do rename the variable as I suggested though, I hope 
> >> that's not a big deal.
> >
> >Jiaxun, are you going to send an update with this change ?
> 
> Sorry my mail server missed Maciej's reply.
> 
> Should I send another version or you just fix it at apply time?

please send a new version, thank you.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]