Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3810236ybz;
        Mon, 4 May 2020 10:07:07 -0700 (PDT)
X-Google-Smtp-Source: APiQypKXNe14d38nRzQuNVs10leMqkhsyROOrL4I7ODmedn0eHiQD+/r2JvyxiMN1lTcgCi3mk68
X-Received: by 2002:a17:906:2f8f:: with SMTP id w15mr16007609eji.255.1588612026951;
        Mon, 04 May 2020 10:07:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588612026; cv=none;
        d=google.com; s=arc-20160816;
        b=N1auYGZc6LQ49rnMuNPqr3W50NpodVAXbUmWjbhXTVGyXZKhvtIWTROs4+t3du2OjD
         hjvZnx9Sz2ss2CqPn6a6d3TVbwlu+NkWjwm6uC4BK8BffhluinlSKU0D9a4vCYyIy7Pf
         HkPMmPcyCSNXOlCv4j2U+wEE0yuyfF2bd+SXXAzURhdoTgSaghg1zrQBfZdG0kK07v77
         VXmooMGUmIMVoJzbYdLQaFIPeRqTVNbmX0hvWPMVWqhRUz6lqolFch5GoPncCnj+e7+F
         Lk8uZoB9wGCwv9yZ6dwo/ysGq2BH7DdTjRsyrYAj/+u0hxhOQh3wZPaaZHTQpEsGq5tJ
         IqXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=tktJ7WPLxDwFWB5a1NMnFjl9b+vUpGdtwpko9tH8NFk=;
        b=nDF+8a1Py1G4bvA+cwVcnR8eQOZr1wGjTVmvUEROPJ80ttb7riu2f06h87YdsPxToi
         BtLQDdkPnDY078IbrHA/bJELPiqDMVfZitDxkScXE9pQFZ+uP46iau0IeeOaiXhKvE7G
         8K+9dgZjrdEW+ViDbpLaajAjFVZpUXgJZHLgogFBhshQrxY6DZ5QgLJfKCc9qpWP6d97
         OxMzVJ9joTNOGKup3WOppIpoqViBVrKOTAVKDfJW9K8ic7fTbAt6zVgI/+mGWbUUybXb
         qUJCJ91JsFwR4oYBQWiHU28QW5AzcRBS8LycmpTkpHWgt6mRQvtkDti4mFCVj2IbhO9t
         grkQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=2BygdSsF;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id q13si7416048eds.115.2020.05.04.10.06.42;
        Mon, 04 May 2020 10:07:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=2BygdSsF;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729738AbgEDRBb (ORCPT <rfc822;austinkernel.kim@gmail.com>
        + 99 others); Mon, 4 May 2020 13:01:31 -0400
Received: from mail.kernel.org ([198.145.29.99]:38712 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729459AbgEDRBa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 May 2020 13:01:30 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 2DAFF206D7;
        Mon,  4 May 2020 17:01:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1588611690;
        bh=mEIMvEeemT9qFPg6WFXv7L2Ou2lEHMX+SClo7n1fkh0=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=2BygdSsFh85R9fAHagGynYsW4TX6sYVTu+7YqhxiotGbO13ggVCuL1iUIFm3mCOnr
         Q4cKHGq7/9wKuwY2yz13s+yWWLDes1Vi1SOBQzfWLaI8K0TxcsRf/xxgOvmgyDn7CL
         NQHTTugxIZCjssiCo3oUd3RgmTOp/3O6Dhx0tY7k=
Date:   Mon, 4 May 2020 10:01:28 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     wu000273@umn.edu
Cc:     davem@davemloft.net, oss-drivers@netronome.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kjlu@umn.edu
Subject: Re: [PATCH] nfp: abm: fix a memory leak bug
Message-ID: <20200504100128.06221170@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200502224259.1477-1-wu000273@umn.edu>
References: <20200502224259.1477-1-wu000273@umn.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat,  2 May 2020 17:42:59 -0500 wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
> 
> In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
> But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
> which can lead to a memory leak bug. Fix this issue by adding
> nfp_nsp_close(nsp) in the error path.
> 
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>

Fixes: f6e71efdf9fb1 ("nfp: abm: look up MAC addresses via management FW")
Acked-by: Jakub Kicinski <kuba@kernel.org>