Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3820902ybz; Mon, 4 May 2020 10:18:13 -0700 (PDT) X-Google-Smtp-Source: APiQypIY6gF+DKttZQILEZ8Pzu5biBaYqZulV1cZXAo8/wtC4m8YIupL1kBQp34KPHQX4hDb73Ck X-Received: by 2002:a05:6402:30bb:: with SMTP id df27mr14859705edb.267.1588612693430; Mon, 04 May 2020 10:18:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588612693; cv=none; d=google.com; s=arc-20160816; b=jiWLifodmtLuvK9g2ZujsH/vO85TmzbcjWAHfe+Gz0XHkIdCb6Hv63oyfEc2/T4JII XAyIFtMDC8VIzj7wZHudIsrdC6Wy98kkK7nf02Gt57mF6oTFO0T0mYT7vZkM9O3oZxtQ 9vzFdxGjVDdKxuii9qm+KJvQUnLeR3v+zGpYQIk5O+tztuwKMxiEboBmsW02Xp/a2M3r D3l/jlb7gnqeoHMSbljibKVft0K3xtnMQM3k9TyYol/jQCd3DHjKkPgHZ0Vm4gULBx0b ifcItEWPQgBcL7YQ0yT0PKAGQSw6+l3YShoxbFSPZylnp+S6n6n8LuttRG9vfpvbRD1d TwBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=RBKVKwQnX8Ke7fDKlpM7e2rayKOe0Pmzlh9egC185qw=; b=aBbtOPEvcMIPIW/2txiC+71JvLkrwnNdKK8KgrubvF6xZLx97NTNRfGPRyIcGuWGN+ sMgH8pLBmCwL4QmBGXc39H+SLzY6lu9WgqI4IMaDYHBRBNi+IiaJtTkKAs++wTYFWgeJ p0MHth0iyG2IMPNxe3SX3vDci0UnzUm7z15zB0jTd+ie2XR7E4Mql9tfuE4PdZelwJSR TLmh9PxByoa5AE8IPKDgtMStxvy0UwmOmj5bVt3sdZ5cEamKGtBSAaU2F8KzwAeUNEKc bUDwUdbJtORgge+h18sMAP3A43tImyLyQaMdIS5vRqMZ5zfKjpuTYIHTL7srL6FgP7DN LiiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si7089653ejh.439.2020.05.04.10.17.49; Mon, 04 May 2020 10:18:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730164AbgEDROu (ORCPT + 99 others); Mon, 4 May 2020 13:14:50 -0400 Received: from foss.arm.com ([217.140.110.172]:49736 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730571AbgEDROn (ORCPT ); Mon, 4 May 2020 13:14:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34D0D1045; Mon, 4 May 2020 10:14:43 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A5753F68F; Mon, 4 May 2020 10:14:42 -0700 (PDT) Subject: Re: [PATCH] firmware: arm_sdei: Drop check for /firmware/ node and always register driver To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "will@kernel.org" , Catalin Marinas References: <20200422122823.1390-1-sudeep.holla@arm.com> From: James Morse Message-ID: Date: Mon, 4 May 2020 18:14:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200422122823.1390-1-sudeep.holla@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudeep, (CC: +Will and +Catalin) On 22/04/2020 13:28, Sudeep Holla wrote: > As with most of the drivers, let us register this driver unconditionally > by dropping the checks for presence of firmware nodes(DT) or entries(ACPI). > > Further, as mentioned in the commit acafce48b07b ("firmware: arm_sdei: > Fix DT platform device creation"), the core takes care of creation of > platform device when the appropriate device node is found and probe > is called accordingly. > > Let us check only for the presence of ACPI firmware entry before creating > the platform device and flag warning if we fail. Reviewed-by: James Morse Will/Catalin, any chance you could pick this up for v5.8? Original message: https://lore.kernel.org/linux-arm-kernel/20200422122823.1390-1-sudeep.holla@arm.com/ Thanks! James