Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3852786ybz; Mon, 4 May 2020 10:55:07 -0700 (PDT) X-Google-Smtp-Source: APiQypIHtTMq/M6N9mFPQP3QpIhox6gfLYsta61tn+eXqHsTS/bSTtHYgPeazKL8FAJXM6mpiMIb X-Received: by 2002:a50:e8cb:: with SMTP id l11mr16540122edn.174.1588614907580; Mon, 04 May 2020 10:55:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588614907; cv=none; d=google.com; s=arc-20160816; b=x0MN872GTV8JCC45xXOAFL38wu0RFg81yl6aDSiA9xSiJuGQhIli02U/rzhiYCJAbd DtjBSwWRBqy5Y1xNd/3seN5UnegdDdNOTy21htUUUVu3yFPFr+HD51c6qVvjT22paZ/Q 4h+XHw6GLTbyZIGbBKHWLaZiKvKAhdz1betCuTcXTDjyQoJqsAzguIdfVAHOOxuDwDBP axltk4EEWAhhDUjIJHvZomf+1XXRqtdAOB1FSb1DBVvLLE52R+cg3xmQhgje5Usl2Pdi ErwC/khyN7ySTTLaHQ9iMTQIULX59DBfu7Krkrexj3k0+47qu49ToJVhSn2ULz8DAWXJ 9e9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=X/zfkUS9i50PX4d5KaXLhMd19wtSdqqQ1k+SPhFvdHk=; b=uMIJKnXFrA7WQMSfN9eBcsCuoH/+aCKUlFOXN4/auOYNbBRF+L2Br/58DKRCTjs4Dd 1IKzZaybhdMfxfJgM2U78hLsSP4GZsVMHc/nAIpqtkLqjcqicTpX9wgzwWsEWzSthrcm sEzTrTfMnBA7rWqKYx2iWdZOJPWCnzpsvTzK8VGha8m6eHyMIH3HiJQZl/eBVyUN/1GL I6lIYOoogv1KdpHLDInINlLAg1n8Ys3VtrfU71pR3xamjvAwM1WiDhcJx1cysXh5ZWxF 8WrQXJCl5/h29MerfFMsh+wkwcPEu3qnxTIKpHk42uJBZQVc1ciCS3y2DJAlmOqe1kGp 4i3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gr21si6667891ejb.482.2020.05.04.10.54.44; Mon, 04 May 2020 10:55:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbgEDRwf (ORCPT + 99 others); Mon, 4 May 2020 13:52:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729937AbgEDRwf (ORCPT ); Mon, 4 May 2020 13:52:35 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09C45C061A0E; Mon, 4 May 2020 10:52:35 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7616915D15A63; Mon, 4 May 2020 10:52:34 -0700 (PDT) Date: Mon, 04 May 2020 10:52:33 -0700 (PDT) Message-Id: <20200504.105233.141268457994511921.davem@davemloft.net> To: zhengdejin5@gmail.com Cc: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com Subject: Re: [PATCH net v1] net: enetc: fix an issue about leak system resources From: David Miller In-Reply-To: <20200504120127.4482-1-zhengdejin5@gmail.com> References: <20200504120127.4482-1-zhengdejin5@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 May 2020 10:52:34 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dejin Zheng Date: Mon, 4 May 2020 20:01:27 +0800 > the related system resources were not released when enetc_hw_alloc() > return error in the enetc_pci_mdio_probe(), add iounmap() for error > handling label "err_hw_alloc" to fix it. > > Fixes: 6517798dd3432a ("enetc: Make MDIO accessors more generic and export to include/linux/fsl") > Cc: Andy Shevchenko > Signed-off-by: Dejin Zheng Applied, thank you.