Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 May 2020 11:29:22 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Christopher Lameter <cl@linux.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>, <linux-mm@kvack.org>,
        <kernel-team@fb.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 04/19] mm: slub: implement SLUB version of
 obj_to_index()
Message-ID: <20200504182922.GA20009@carbon.dhcp.thefacebook.com>
References: <20200422204708.2176080-5-guro@fb.com>
 <alpine.DEB.2.21.2004222349280.20021@www.lameter.com>
 <20200423000530.GA63356@carbon.lan>
 <alpine.DEB.2.21.2004250208500.7624@www.lameter.com>
 <20200425024625.GA107755@carbon.lan>
 <alpine.DEB.2.21.2004271618340.27701@www.lameter.com>
 <20200427164638.GC114719@carbon.DHCP.thefacebook.com>
 <alpine.DEB.2.21.2004301625490.1693@www.lameter.com>
 <20200430171558.GA339283@carbon.dhcp.thefacebook.com>
 <alpine.DEB.2.22.394.2005022353330.1987@www.lameter.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2005022353330.1987@www.lameter.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:cc1a) by BYAPR07CA0017.namprd07.prod.outlook.com (2603:10b6:a02:bc::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19 via Frontend Transport; Mon, 4 May 2020 18:29:24 +0000
X-Originating-IP: [2620:10d:c090:400::5:cc1a]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 426aa318-4e5d-45b9-2757-08d7f05912ba
X-MS-TrafficTypeDiagnostic: BYAPR15MB2645:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB2645F8933DCC7E70E8BE8153BEA60@BYAPR15MB2645.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-Forefront-PRVS: 03932714EB
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3qv4Aabn0ItGUrLgUAeLDutg87RDyMKizt7OxYxAJS+XBdxTeGCo+FKwnuS+W6DwOz4jnZ6/hCiZNmEBD5VONVDo4BTtmYYRO0Fqsdyplh5o3RxXKyG0BH8hCPYbmW7OqAYPbWQv29qyZlFC7+iqDEEpjDpIZsdG54m9Yd5u0l8crB21N4pBA4+M4zOF9mJzwolFVTkOmZk3KCJ7h20QthoYw+aGYx3ikjuLlX6FJU8fL0upSMmSmHxrEv4zvBv4kX8acMeeWgOlMXfF2GJG7z2eEoveuYVy8FFFFzcCeUmYJEiTdiCeVXl1Cl7xGDaehQeamH6LDrtbr1iTCKnB1gDHXIJ6nZWIOD87nWgCZmacpOsQubaT7XBQVeZsalWGW4dregbAsjGXudnabyPzaBSvYxqPbm2ogEFjFHHo9DK91y85bQleVu7W1vVDtgPt
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(346002)(136003)(366004)(39860400002)(396003)(5660300002)(6916009)(66946007)(66476007)(66556008)(2906002)(8676002)(16526019)(8936002)(1076003)(186003)(478600001)(6506007)(4326008)(54906003)(33656002)(86362001)(316002)(9686003)(7696005)(52116002)(55016002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: dO50jlkfEWPdKbeNixoKmsfumtPxREjvJ14DSYHNvXPuWatz9KOaMURi+aAe9M77k0WGD5wbIshifNMI4yqn3LfQFtDRYh4RzikJ/RRfeT1WTHKAV6/7C27ZKzce2mrtgxiwp7PYVE9W0S5u0oHQZFxyKYXcCzLMEuYGDCzNCBfV79hEs/O1X3aQDf9RY2+Oc5p8x2jPOPUSm/CK2wU0M1zVRR3hmu1lQgYjx1OK558YugGpTAwhqsmxCKGWLXGfyjQl0OayoSUtvwI05jFjNjtOtPmtyfHiaZRXmS/6lkgSTo70iPFNPV/5izKJv/ScvXeBD1zWBvPjdqrj+5wJqiWowuSssGjVJGFAJ7NOw8zBFvWIaejSUQq+7u4wx+/n87T8HuikUBZOXcxoo+iCNiJSIDqIzahlXb4XD26WMknAh7Hn5UbhvqjJPkq+cVgJ+nNqekzZhc0zhYyR41YnHptCdMUtYsFe+qFAvbpFAmGmHXczxSN7dGGZvE/I3zJMSK7qeD/YpwZXZNDlFCtlhpzM3MIFw+vN92Ow3FvszSgUZWF0Gn+io7vNtp7DxDFMmtk5ABFjPXMzNExA62ZazpIbXEgGFDCrsPjBeVr5/GF2r+Ktet6pZdLTKXRU36linmDm5s2cVA4jr7K4WIG7ogKQ8p1V5GUT4um8tSeb9srU6qg//l7sBLNFD9g0/W0fIhfTDpi92+2wEEMuSeK/qzY+a4NEulKpxeP+DHD5mYZMMsx1cvYVi+onG7qxNkoRdQ0xFRHS3rTxxDIblXM9yTc5iG6EGKRD8tmEyt5QEFuemA71SqD0H2AeVRdW0P7o2yjwdAoIqmbslwrcD6qm9g==
X-MS-Exchange-CrossTenant-Network-Message-Id: 426aa318-4e5d-45b9-2757-08d7f05912ba
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2020 18:29:25.5188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iR9Y8G4Krq/tDF+9nBtmp21zI5jGaVoIgUgj06t4b8xNLHZtWXhS2toqT2cKwjSR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2645
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-05-04_11:2020-05-04,2020-05-04 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0
 bulkscore=0 suspectscore=1 adultscore=0 malwarescore=0 impostorscore=0
 phishscore=0 mlxscore=0 mlxlogscore=580 priorityscore=1501 clxscore=1015
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2003020000 definitions=main-2005040144
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 02, 2020 at 11:54:09PM +0000, Christoph Lameter wrote:
> On Thu, 30 Apr 2020, Roman Gushchin wrote:
> 
> > Sorry, but what exactly do you mean?
> 
> I think the right approach is to add a pointer to each slab object for
> memcg support.
>

As I understand, embedding the memcg pointer will hopefully make allocations
cheaper in terms of CPU, but will require more memory. And you think that
it's worth it. Is it a correct understanding?

Can you, please, describe a bit more detailed how it should be done
from your point of view?
I mean where to store the pointer, should it be SLAB/SLUB-specific code
or a generic code, what do to with kmallocs alignments, should we
merge slabs which had a different size before and now have the same
because of the memcg pointer and aligment, etc.

I'm happy to follow your advice and perform some tests to get an idea of
how significant the memory overhead is and how big are CPU savings.
I guess with these numbers it will be easy to make a decision.

Thanks!